From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Alejandro Lucero" <alejandro.lucero@netronome.com>,
"Pablo Cascón" <pablo.cascon@netronome.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/1] net/nfp: fix set_mac_addr
Date: Mon, 11 Mar 2019 16:52:01 +0000 [thread overview]
Message-ID: <0f95e27a-9f93-4ae0-e02a-8e8778a8ddbe@intel.com> (raw)
In-Reply-To: <CAD+H993zSAxyN79kJc3oHtx6x9Xn5ej48E25MEiuq0nEkmCVVg@mail.gmail.com>
On 3/10/2019 11:42 AM, Alejandro Lucero wrote:
> On Fri, Mar 8, 2019 at 3:41 PM Pablo Cascón <pablo.cascon@netronome.com>
> wrote:
>
>> Some firmwares, mostly for VFs, do not advertise the feature /
>> capability of changing the MAC address while the interface is up. With
>> such firmware a request to change the MAC address that at the same
>> time also tries to enable the not available feature will be denied by
>> the firmware resulting in an error message like:
>>
>> nfp_net_reconfig(): Error nfp_net reconfig for ctrl: 80000000 update: 800
>>
>> Fix set_mac_addr by not trying to enable a feature if it is not
>> advertised by the firmware.
>>
>> Fixes: 2fe669f4bcd2 ("net/nfp: support MAC address change")
>>
>> Signed-off-by: Pablo Cascón <pablo.cascon@netronome.com>
>>
> Acked-by: Alejandro Lucero <alejandro.lucero@netronome.com>
>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2019-03-11 16:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 15:40 [dpdk-dev] " Pablo Cascón
2019-03-10 11:42 ` Alejandro Lucero
2019-03-11 16:52 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f95e27a-9f93-4ae0-e02a-8e8778a8ddbe@intel.com \
--to=ferruh.yigit@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=pablo.cascon@netronome.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).