From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 7555B691A for ; Wed, 26 Apr 2017 10:02:45 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8D50C7F4DE; Wed, 26 Apr 2017 08:02:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8D50C7F4DE Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=maxime.coquelin@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8D50C7F4DE Received: from [10.36.112.43] (ovpn-112-43.ams2.redhat.com [10.36.112.43]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 96C2B18103; Wed, 26 Apr 2017 08:02:43 +0000 (UTC) To: Yuanhan Liu Cc: Zhiyong Yang , dev@dpdk.org References: <1490960419-16779-2-git-send-email-zhiyong.yang@intel.com> <1492583361-43601-1-git-send-email-zhiyong.yang@intel.com> <09fa9de3-b186-5949-d3a0-93e90064a357@redhat.com> <20170426075641.GI11512@yliu-dev.sh.intel.com> From: Maxime Coquelin Message-ID: <0fa29ea8-31dc-9a4a-9361-92ff2b1cf6a3@redhat.com> Date: Wed, 26 Apr 2017 10:02:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <20170426075641.GI11512@yliu-dev.sh.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 26 Apr 2017 08:02:44 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2] net/virtio: support to turn on/off traffic flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Apr 2017 08:02:45 -0000 On 04/26/2017 09:56 AM, Yuanhan Liu wrote: > On Wed, Apr 26, 2017 at 09:45:42AM +0200, Maxime Coquelin wrote: >> As said, only cosmetic comments, it looks otherwise valid to me. >> If you fix these, feel free to add my: >> Acked-by: Maxime Coquelin > > Oops, I forgot to reply this thread, that I have already applied it :/ No worries, not a big deal :) The fix is valid, which is the most important. Cheers, Maxime