From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7182FA0093; Wed, 21 Dec 2022 07:10:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54C3040698; Wed, 21 Dec 2022 07:10:00 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 3FA1F40684 for ; Wed, 21 Dec 2022 07:09:59 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 3DF7B59; Wed, 21 Dec 2022 09:09:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 3DF7B59 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1671602998; bh=WFa0JGq+VtYAkOAleM8QkJiMd69olffrAYzJ23lqx8Q=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZqCiDs3NkC6qpoBNfzRu+6avThTbHtrnlio/+CSb8GdWXZzzmwwue2Sq34Mn9mCRr AgE4upihzUSaXy0vRu7fsM4FdfTsIpabkaMgDqOq9olruSOUn622d2A79pEkmuOSnq 9Q+gC8f1VhW0qU8RxERMWGvlKaDiJORh787hnDDw= Message-ID: <0fcfe78a-72c6-788d-867e-0ff554ba5004@oktetlabs.ru> Date: Wed, 21 Dec 2022 09:09:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] net/af_xdp: make compatible with libbpf v0.8.0 Content-Language: en-US To: Kevin Traynor , Ciara Loftus , dev@dpdk.org, "Zhang, Qi Z" Cc: thomas@monjalon.net, ferruh.yigit@xilinx.com References: <20220624102354.1516606-1-ciara.loftus@intel.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Kevin, On 12/20/22 17:05, Kevin Traynor wrote: > On 24/06/2022 11:23, Ciara Loftus wrote: >> libbpf v0.8.0 deprecates the bpf_get_link_xdp_id and bpf_set_link_xdp_fd >> functions. Use meson to detect if libbpf >= v0.7.0 is linked and if >> so, use >> the recommended replacement functions bpf_xdp_query_id, bpf_xdp_attach >> and bpf_xdp_detach which are available to use since libbpf v0.7.0. >> >> Also prevent linking with libbpf versions > v0.8.0. >> >> Signed-off-by: Ciara Loftus > > Hi Andrew/Qi (assuming Ciara is still out of office), > > I am seeing a similar issue [1] on 21.11 branch with Fedora 37 > (libbpf-0.8.0-2.fc37.x86_64 and libxdp-1.2.6-1.fc37.x86_64). > > This patch alone won't apply as there are other dependencies. Looking at > the commits in main branch, it seems like I could take all these [2] to > resolve the issue. With these cherry-picked the build warnings on Fedora > 37 are removed. > > It's a bit late to take these for DPDK 21.11.3 as I intend to release > later today/tomorrow, so it can be resolved for DPDK 21.11.4. > > Do the commits below look ok for backport? Main branch might be able to > demand user uses new libbpf/libxdp versions etc, but with stable we > never want to break the users existing setup when they upgrade from > 2X.11.n to 2X.11.n+1. > > Let me know what you think? IMO these patches are to to be backported to stable branch. However, af_xdp maintainers opinion is more important here. > > thanks, > Kevin. > > [1] https://paste.centos.org/view/e4eec764 > [2] > 1eb1846b1a net/af_xdp: make compatible with libbpf 0.8.0 > 5ff3dbe6ce net/af_xdp: add log on XDP program removal failures > 0ed0bc3834 net/af_xdp: avoid version-based check for program load > e024c7e838 net/af_xdp: avoid version-based check for shared UMEM > f76dc44ded net/af_xdp: make clear which libxdp version is required > 50b855fc47 net/af_xdp: move XDP library presence flag setting >