From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D0E91A0032;
	Fri, 21 Oct 2022 10:00:04 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BA81F4281C;
	Fri, 21 Oct 2022 10:00:04 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id A9363400D6
 for <dev@dpdk.org>; Fri, 21 Oct 2022 10:00:03 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id D7C8569;
 Fri, 21 Oct 2022 11:00:02 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru D7C8569
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1666339202;
 bh=FfnCPHmKrFJpXS9yupjzrBg+9Sl6tPk19GhdP77xwU0=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=knGIO0RE2hYU+yqxORJbcyUHHl7FdeeJF2sBi1WbaYns6MYmEjT2RZsY626fAYZhR
 qt5kmWw7cLRQaXWuKcUt0WF4t2cOnKKuZ7Dgcvmm2xGNmzIf8G9IYax81YrZjSJVQX
 bhqkPdzATpCHuoRsaiebq+kOyzt3v+QqRbSFm3wQ=
Message-ID: <0ffd97e8-4d21-19cf-cb23-ed1354242b85@oktetlabs.ru>
Date: Fri, 21 Oct 2022 11:00:02 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v9 07/14] net/idpf: add support for packet type get
Content-Language: en-US
To: Junfeng Guo <junfeng.guo@intel.com>, qi.z.zhang@intel.com,
 jingjing.wu@intel.com, beilei.xing@intel.com
Cc: dev@dpdk.org, Wenjun Wu <wenjun1.wu@intel.com>
References: <20221020062951.645121-2-junfeng.guo@intel.com>
 <20221021051821.2164939-1-junfeng.guo@intel.com>
 <20221021051821.2164939-8-junfeng.guo@intel.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20221021051821.2164939-8-junfeng.guo@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 10/21/22 08:18, Junfeng Guo wrote:
> Add dev ops dev_supported_ptypes_get.

It is nice, but I don't see code on datapath which
actually provides the packet type information.
Basically just after the patch you can't pretend
that it is actually supported since there is no
datapath yet. Also it does not allow me to check
the consistency - i.e. really check that datapath
supports all reported packet types.