From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FF2342672; Fri, 29 Sep 2023 12:26:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 167AD40DCE; Fri, 29 Sep 2023 12:26:50 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 50DD040287; Fri, 29 Sep 2023 12:26:49 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 009265C00FE; Fri, 29 Sep 2023 06:26:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 29 Sep 2023 06:26:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1695983208; x=1696069608; bh=X0FpJX+d3p/hPFfysKfXHnJru0NaX4yX/7V WblRlpiI=; b=mGn6I8IZepBtVokNBgS0bPX8YGYR4TcEYxdmeYkSiQdhFpispKQ 4KyIG0p+wbU/WIfugKSEkSCFN3uN9m5vgvnt1SB+TIyfZczIueanTM2ocA7smoDS n13jbVo+I4wq1ul5boLkYEUCGnp7v/J4Xy8ESsVDoyBXmzca+5EWrZzBY7x9b0nG g1hWJoimz9+YY3iVZd9jXWIA3koRax2CxmnPkneka97w2THCGMVFu7zSib6jhUP5 bZL9c4TJpRkzDuSkshHaNj1sc4jlmFXZi7RaX4wGsJgLj9PV1JPJBmosfCZQARiR XLsbZkksTaBAsJ/Guiz4ATdEmQ3USiX0Qsg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1695983208; x=1696069608; bh=X0FpJX+d3p/hPFfysKfXHnJru0NaX4yX/7V WblRlpiI=; b=Y9CEdE+txVNt/LHu4wbjW1D4mkmmyL7haNQ3MTdBWcmCP0gcgo4 uKLbq4cjni0ipAPeoWUCiCewifPk3Kb6yBca7IvoT/PAOD1yrT5vcyB0hI2wQwWj 43bpDhsKvk4wAi5dqB+7ERPwq3/akEJYBTEkHFq+sKDHjcSDSacZtGgzF/UlU05h ctDl+fcQFEAmoqW+GuW5RYTdrHeB//PaK/2emXvn2amcEeKeoGAqIrC2udyzSsdO VSKEkAL1rM5Cnjez/0gZIz7wi6Xz2MC8lLF0i7jCbujPnCI3DMN9lsXnvcZhs1Kl xV9lCDOl5ddxKsja/39rbElAfvSc4mYS7eg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrtddvgddvkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedviedu vdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 29 Sep 2023 06:26:46 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson , David Marchand Cc: Morten =?ISO-8859-1?Q?Br=F8rup?= , Tyler Retzlaff , dev@dpdk.org, techboard@dpdk.org, Honnappa Nagarahalli , Ruifeng Wang , Jerin Jacob , Sunil Kumar Kori , Mattias =?ISO-8859-1?Q?R=F6nnblom?= , Joyce Kong , David Christensen , Konstantin Ananyev , David Hunt Subject: Re: [PATCH v6 1/6] eal: provide rte stdatomics optional atomics API Date: Fri, 29 Sep 2023 12:26:45 +0200 Message-ID: <10054797.lvqk35OSZv@thomas> In-Reply-To: References: <1691717521-1025-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 29/09/2023 11:34, David Marchand: > On Fri, Sep 29, 2023 at 11:26=E2=80=AFAM Bruce Richardson > wrote: > > > > On Fri, Sep 29, 2023 at 11:02:38AM +0200, David Marchand wrote: > > > On Fri, Sep 29, 2023 at 10:54=E2=80=AFAM Morten Br=C3=B8rup wrote: > > > > In my opinion, our move to C11 thus makes RTE_BUILD_BUG_ON obsolete. > > > > > > That's my thought too. > > > > > > > > > > > We should mark RTE_BUILD_BUG_ON as deprecated, and disallow RTE_BUI= LD_BUG_ON in new code. Perhaps checkpatches could catch this? > > > > > > For a clear deprecation of a part of DPDK API, I don't see a need to > > > add something in checkpatch. > > > Putting a RTE_DEPRECATED in RTE_BUILD_BUG_ON directly triggers a build > > > warning (caught by CI since we run with Werror). > > > > > > > Would it not be sufficient to just make it an alias for the C11 static > > assertions? It's not like its a lot of code to maintain, and if app use= rs > > have it in their code I'm not sure we get massive benefit from forcing = them > > to edit their code. I'd rather see it kept as a one-line macro purely f= rom > > a backward compatibility viewpoint. We can replace internal usages, tho= ugh > > - which can be checked by checkpatch. >=20 > No, there is no massive benefit, just trying to reduce our ever > growing API surface. >=20 > Note, this macro should have been kept internal but it was introduced > at a time such matter was not considered... I agree with all. Now taking techboard hat, we agreed to avoid breaking API if possible. So we should keep RTE_BUILD_BUG_ON forever even if not used. Internally we can replace its usages.