From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id A43352C54 for <dev@dpdk.org>; Sun, 20 Mar 2016 11:31:24 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id l68so77214151wml.0 for <dev@dpdk.org>; Sun, 20 Mar 2016 03:31:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=rduLNf+SjYpKgyOjCjiBkxtt+HckSIcVxAbME+n3Aog=; b=P0Xj3sAVJunJ6tsgjVKODT+h9DYQNwnOQWFlapWT0d7jfWqamKrht+7mTyKb7ZvQem vDME1RR/QRmuBa401Vy8eXoSXctFYn+UtrYDdoLnaXrFLSgoEsQq0SWAjx8d6bJ44Agp XnHAz/si2mErxuhwBGBEApb0pWi+RQQTVPeCEpZRpRe4lgpgnjgM7JLHMcQ2LWveEIZs KlnJ/zhcOIE5eRp1hpO5kfQEyqnwuCaAQAvS8GXbxRfxlvb6b90Aj40EuwJfWxvg4Cmq EDvHsTu8xMmUgvPgvGIQFrQrVuyXSJMOvTlmyLw+Cs0XQ1NTM60IYURkjINIRVyNj06h 7PKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=rduLNf+SjYpKgyOjCjiBkxtt+HckSIcVxAbME+n3Aog=; b=Cnmxocm7c4zjoVntoOGw3SfQoT5y6ZP1a/bneNVPfuWqN+y5hv9JBqamfgazksu88Q QLWMi7hdjf3Gsm0NmlGBr8tWrWgV/D9669yK45xOFLtQbHnsntdncRqYRqksh/YSLS8f QooJcijPQ2/BWyTZyFTNchEIdMHZG2wfw6fE/vd/Fbt2OA0p8S+WQOacvC8DtzIpghh+ CmcSQ9omY3tS9TWALrBhPiQHkbZfGho4aSSIDmFJ6X7CrRrWCbNUEpky58UiKhECv9lJ I6DTVANggq4LCXiqsgayN8inMI5c3Oe1PD0hxzS+1MLdIHJeKTOoabZPnDVT6p6rM2+i naYg== X-Gm-Message-State: AD7BkJIoujedntAyTMYzRNujyLyYt1fjELtQmZu3eEov+2CGRGGOEEUQaqW3ftQJFAosZ+gb X-Received: by 10.194.63.144 with SMTP id g16mr28489490wjs.149.1458469884473; Sun, 20 Mar 2016 03:31:24 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id i1sm20032228wjs.45.2016.03.20.03.31.23 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 20 Mar 2016 03:31:23 -0700 (PDT) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Jan Viktorin <viktorin@rehivetech.com> Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, tomaszx.kulasek@intel.com, jianbo.liu@linaro.org Date: Sun, 20 Mar 2016 11:29:48 +0100 Message-ID: <10088842.WxuXTY5r1p@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160320104110.3c05f405@jvn> References: <1458417485-29436-1-git-send-email-viktorin@rehivetech.com> <1752293.0PmA76bAcf@xps13> <20160320104110.3c05f405@jvn> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 4/4] eal/arm: introduce CONFIG_RTE_ARCH_ARM_NEON_MEMCPY X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Sun, 20 Mar 2016 10:31:24 -0000 2016-03-20 10:41, Jan Viktorin: > On Sat, 19 Mar 2016 21:14:57 +0100 > Thomas Monjalon <thomas.monjalon@6wind.com> wrote: > > > 2016-03-19 20:58, Jan Viktorin: > > > The flag is used to enable memcpy optimizations in EAL. As it is not always > > > the performance benefit, the flag allows to disable it. > > > > Ideally the default should be to choose the best optimization. > > If it is not possible, it would help to have some comments explaining > > how to choose wether enabling NEON memcpy or not. > > Ok, we can rename the option to CONFIG_RTE_ARCH_ARM_AVOID_NEON_MEMCPY, > delete it from the defconfig and change the test in rte_memcpy_32.h to > > #ifndef CONFIG_RTE_ARCH_ARM_AVOID_NEON_MEMCPY > > Alternatively, to have a positive test like > > #ifdef CONFIG_RTE_ARCH_ARM_AVOID_NEON_MEMCPY > > I can create a bigger change that moves the non-neon-memcpy up in the > file... > > Should I resend the whole series as v3? No, I don't think changing the name of the config or moving code will change anything. We just need to understand when it must be enabled or disabled.