DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org, olivier.matz@6wind.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/bpf: fix compilation issue
Date: Tue, 30 Jul 2019 19:53:01 +0200	[thread overview]
Message-ID: <10104652.MOWmfaWtsW@xps> (raw)
In-Reply-To: <20190730101927.1665-1-konstantin.ananyev@intel.com>

30/07/2019 12:19, Konstantin Ananyev:
> Example BPF programs t1.c, t2.c, t3.c in folder examples/bpf are
> failing to compile with latest dpdk.org master.
> The reason is changes in some core DPDK header files, that causes
> now inclusion of x86 specific headers.
> To overcome the issue, minimize inclusion of DPDK header files
> into BPF source code.
> 
> Bugzilla ID: 321
> 
> Fixes: 9dfc06c26a8b ("test/bpf: add samples")
> Cc: stable@dpdk.org
> 
> Reported-by: Michel Machado <michel@digirati.com.br>
> Suggested-by: Michel Machado <michel@digirati.com.br>
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> ---
>  examples/bpf/mbuf.h | 24 ++++++++++++++++++++++--
>  1 file changed, 22 insertions(+), 2 deletions(-)

I think that's really a bad idea to have this file.
The BPF applications are supposed to update their own copy of mbuf?
Please could you try to include rte_mbuf.h
instead of duplicating the mbuf layout?




  reply	other threads:[~2019-07-30 17:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 10:19 [dpdk-dev] " Konstantin Ananyev
2019-07-30 17:53 ` Thomas Monjalon [this message]
2019-07-31  7:26   ` [dpdk-dev] [dpdk-stable] " Ananyev, Konstantin
2019-08-06 10:32     ` Thomas Monjalon
2019-07-31  3:16 ` [dpdk-dev] " Varghese, Vipin
2019-07-31  7:04   ` Ananyev, Konstantin
2019-07-31  8:20     ` Varghese, Vipin
2019-07-31  8:22       ` Ananyev, Konstantin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10104652.MOWmfaWtsW@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).