From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0408A42B91; Wed, 24 May 2023 22:47:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7AB394067E; Wed, 24 May 2023 22:47:49 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 830FB40156 for ; Wed, 24 May 2023 22:47:48 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 58A593200B1C; Wed, 24 May 2023 16:47:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 24 May 2023 16:47:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1684961266; x=1685047666; bh=umoiPTe3nxjWKN60R3jhrl1CIwrt/jCMrZp tmCxnuyE=; b=G3iCqr0FsdpH66NbxCAiFTVEMBPLLQEEuJhZPFStVyIR2YwkdYm uov7IGYreKT6JSf+s8WonMs7Mb4dgmKCS7KJqtZlmrMhabynC3XmA2SMEPYudmWp V0dD8CBHi7rRM4do+mqziAbWfcr5fteOz73AMoVbCyw9ILT0h9pPPuUXONmbTKCV 4JfDjlLeK44l5WUgVICyttpuJLKczdfDLA/zOtE6KxcPHER6lg69giOMX8TOrZ+c qtpiiu41PNJvtHqGPla+jNgiJMO+Qh9mLDzlWhErOJitFUvEgXmx5KsOBGj/L6Kq NJ/JwUnKhkSI/Hxs2U4nF4VYzxN4r/3wwvg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1684961266; x=1685047666; bh=umoiPTe3nxjWKN60R3jhrl1CIwrt/jCMrZp tmCxnuyE=; b=e+4apuLcR4Pg7LI4CHc+QaTte7RxHfkGq2rlWPq648oDjRAMwPE TZ9gej0kbvIQG3/H5QUnQfAZdyJ1MXkOSw4ZjAWYe2ar9Aaz6gbfeFWv65c0QI/P z8iSmt1kdOZgHqu3ipg8LmnHoGae++Zd7kaJKVwJJaB6CyvgxdiCV7WJ1YLnmhb7 i8aXbWcp+GWLpFS2uMNd8u+ffmne6V9etB3eZlSzsQfoxIth+d7anoTS9kfuj6io z0vH18CpnoaEGbQTX2cJ6dJ8+47GYZy/5CTQDF+bUGSdkJ3kx8ZsznLDkSh36TAl g4YojOylfw6xseKfU1An5C9lyk+QCuz6lTg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejhedgudehtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 24 May 2023 16:47:46 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, ciara.power@intel.com, roretzla@linux.microsoft.com Subject: Re: [PATCH v3 0/5] telemetry: remove variable length arrays Date: Wed, 24 May 2023 22:47:44 +0200 Message-ID: <10152954.0AQdONaE2F@thomas> In-Reply-To: <20230405160326.186921-1-bruce.richardson@intel.com> References: <20230310181836.162336-1-bruce.richardson@intel.com> <20230405160326.186921-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 05/04/2023 18:03, Bruce Richardson: > This patchset introduces a series of changes to remove variable-length > arrays from the telemetry code. The first patch replaces a VLA with > malloc memory for the serialization of the json objects contained within > the main response object, which fixes a crash observed on alpine linux. > > Subsequent patches rework the json printing code to avoid the use of > temporary buffers where possible, or use malloc-allocated memory where > not. > > Based off testing with the unit tests for telemetry, json serialization > for the telemetry callbacks should always use the path where a temporary > buffer is *not* used, but the allocation-case is kept to ensure that any > unexpected edge-cases are covered too. > > V3: remove use of non-standard asprintf function in patch 2. > > V2: expand from single fix for Alpine, to general cleanup to remove VLAs > > Bruce Richardson (5): > telemetry: fix autotest failures on Alpine > telemetry: remove variable length array in printf fn > telemetry: split out body of json string format fn > telemetry: rename local variables > telemetry: remove VLA in json string format function Applied, thanks.