From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 8C5BC1B10D; Wed, 27 Mar 2019 11:31:08 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1C8AB21B2A; Wed, 27 Mar 2019 06:31:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 27 Mar 2019 06:31:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=khcrulzmZMvZDiNiFteWkRBt2AY1O/uebMSe+VBQKas=; b=PiTDtVHxCzgS 8QLtOUK8sPbNmuaZeikhfG02e+/HbIoXBqyVr2fvKJFVSIVA7/NaCsPx3ozGRGNu VJ/2qzFS23R1ctLBwb9Bx4QnB0mxKeVz2Ag50/SLxwmZu9gy17oDScq3VPt24/zC Y2sEPI+ymblxM71/1R/PaD7Ew7Tqv4c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=khcrulzmZMvZDiNiFteWkRBt2AY1O/uebMSe+VBQK as=; b=VE6oLoEXELVs5bMXyCDkaYy3L5QJUBUUM7G3pFOEJZtbHHMki0riwm4Vy fmRVn3NZ9as4hdYqqTrsRkz4iSzgL4U2dJebFnLSBZdsPbasHAwLMYAkjIxlc9UF sHllCqNjiUe3/i2IeynDG1gMj+WVTDD6yYQMcA6Q8rFa4InyJQFFa1+YBxcTnXma UxvxiYhdG4JpqoAEjUYn+iemdbs7WI7yNBw6iDogh7E5ctORLe9wEjGQpwy2yOHI ZmFsqjdpSUwfB6EXb4oXIb8abIYuzP/A+BuBkYGPgfbQ0MhZlwe0TL6mhssu6JoY yIy3ujEwar9Kay9iO/kNEuFLscTgQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkedvgddufecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7E111E4424; Wed, 27 Mar 2019 06:31:06 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, stable@dpdk.org Date: Wed, 27 Mar 2019 11:31:05 +0100 Message-ID: <10158735.WBPJjXTH6e@xps> In-Reply-To: <72f990b04219f319b2922570a7ca7b9ce93e0aae.1550851129.git.anatoly.burakov@intel.com> References: <72f990b04219f319b2922570a7ca7b9ce93e0aae.1550851129.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] mem: warn user when running without NUMA support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Mar 2019 10:31:08 -0000 22/02/2019 16:59, Anatoly Burakov: > Running in non-legacy mode on a NUMA-enabled system without libnuma > is unsupported, so explicitly print out a warning when trying to > do so. >=20 > Running in legacy mode without libnuma is still supported whether or > not we are running with libnuma support enabled, so also fix init to > allow that scenario. >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: Anatoly Burakov > --- > --- a/lib/librte_eal/linuxapp/eal/eal_memory.c > +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c > @@ -50,6 +50,7 @@ > #include "eal_internal_cfg.h" > #include "eal_filesystem.h" > #include "eal_hugepages.h" > +#include "eal_options.h" I'm seeing this error: lib/librte_eal/common/eal_options.h:74:28: error: array type has incomplete element type =E2=80=98struct option=E2=80=99 extern const struct option eal_long_options[]; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id AB0BBA05D3 for ; Wed, 27 Mar 2019 11:31:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6C7871B111; Wed, 27 Mar 2019 11:31:10 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 8C5BC1B10D; Wed, 27 Mar 2019 11:31:08 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1C8AB21B2A; Wed, 27 Mar 2019 06:31:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 27 Mar 2019 06:31:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=khcrulzmZMvZDiNiFteWkRBt2AY1O/uebMSe+VBQKas=; b=PiTDtVHxCzgS 8QLtOUK8sPbNmuaZeikhfG02e+/HbIoXBqyVr2fvKJFVSIVA7/NaCsPx3ozGRGNu VJ/2qzFS23R1ctLBwb9Bx4QnB0mxKeVz2Ag50/SLxwmZu9gy17oDScq3VPt24/zC Y2sEPI+ymblxM71/1R/PaD7Ew7Tqv4c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=khcrulzmZMvZDiNiFteWkRBt2AY1O/uebMSe+VBQK as=; b=VE6oLoEXELVs5bMXyCDkaYy3L5QJUBUUM7G3pFOEJZtbHHMki0riwm4Vy fmRVn3NZ9as4hdYqqTrsRkz4iSzgL4U2dJebFnLSBZdsPbasHAwLMYAkjIxlc9UF sHllCqNjiUe3/i2IeynDG1gMj+WVTDD6yYQMcA6Q8rFa4InyJQFFa1+YBxcTnXma UxvxiYhdG4JpqoAEjUYn+iemdbs7WI7yNBw6iDogh7E5ctORLe9wEjGQpwy2yOHI ZmFsqjdpSUwfB6EXb4oXIb8abIYuzP/A+BuBkYGPgfbQ0MhZlwe0TL6mhssu6JoY yIy3ujEwar9Kay9iO/kNEuFLscTgQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkedvgddufecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7E111E4424; Wed, 27 Mar 2019 06:31:06 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, stable@dpdk.org Date: Wed, 27 Mar 2019 11:31:05 +0100 Message-ID: <10158735.WBPJjXTH6e@xps> In-Reply-To: <72f990b04219f319b2922570a7ca7b9ce93e0aae.1550851129.git.anatoly.burakov@intel.com> References: <72f990b04219f319b2922570a7ca7b9ce93e0aae.1550851129.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] mem: warn user when running without NUMA support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190327103105.4l-ZQckPnDsmBShg_b1bzXV38n9jFrsXkaCQtfa-32I@z> 22/02/2019 16:59, Anatoly Burakov: > Running in non-legacy mode on a NUMA-enabled system without libnuma > is unsupported, so explicitly print out a warning when trying to > do so. >=20 > Running in legacy mode without libnuma is still supported whether or > not we are running with libnuma support enabled, so also fix init to > allow that scenario. >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: Anatoly Burakov > --- > --- a/lib/librte_eal/linuxapp/eal/eal_memory.c > +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c > @@ -50,6 +50,7 @@ > #include "eal_internal_cfg.h" > #include "eal_filesystem.h" > #include "eal_hugepages.h" > +#include "eal_options.h" I'm seeing this error: lib/librte_eal/common/eal_options.h:74:28: error: array type has incomplete element type =E2=80=98struct option=E2=80=99 extern const struct option eal_long_options[];