From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Olivier MATZ <olivier.matz@6wind.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Andrew Rybchenko <arybchenko@solarflare.com>, <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH] net: update licence for network headers
Date: Wed, 13 Dec 2017 10:43:05 +0530 [thread overview]
Message-ID: <1018d643-eb39-cd23-4094-9ae2a4bcd860@nxp.com> (raw)
In-Reply-To: <20171212165744.v2zsffollkwj54az@platinum>
On 12/12/2017 10:27 PM, Olivier MATZ wrote:
> On Mon, Dec 11, 2017 at 09:56:40AM -0800, Ferruh Yigit wrote:
>> On 12/10/2017 9:27 PM, Hemant Agrawal wrote:
>>> Hi all,
>>> Most templates are showing copyright first and SPDX later i.e. the
>>> typical way for writing the license.
>>>
>>> However some projects has followed it other way around to make it easy
>>> for tools i.e. the TOP line.
>>>
>>> I agree with Ferruh that we shall follow single convention. I will
>>> prefer to do it in following way to make it consistent. (I will also fix
>>> my change patches).
>>>
>>> >> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER
>>> >> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER-2
>>> >> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER-3
>>> >> SPDX-License-Identifier: BSD-3-Clause
>>
>> Stephen mentioned Linux already has a defined syntax for this, unless there is a
>> good reason to change I think we can follow same syntax, what do you think?
>
> As far as I can see, it's not yet integrated in Linux. The latest
> documentation I can find as of today is:
> https://patchwork.kernel.org/patch/10091607/
>
> About the first line:
>
> """
> The SPDX license identifier in kernel files shall be added at the first
> possible line in a file which can contain a comment. For the majority
> """
>
> Some recomandations look a bit inconsistent to me, but I didn't follow
> all the history:
>
> """
> C source: // SPDX-License-Identifier: <SPDX License Expression>
> C header: /* SPDX-License-Identifier: <SPDX License Expression> */
> """
>
>
I tried to study the other repositories using the SPDX tagging e.g.
uboot (http://git.denx.de/?p=u-boot.git;a=tree) and odp etc. They
followed the syntax of copyright followed by SPDX.
Also, typically all dpdk files starts with "/*-", I am not sure about
the purpose of the "-"?
> Olivier
>
next prev parent reply other threads:[~2017-12-13 5:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 10:28 Olivier Matz
2017-12-08 17:29 ` Ferruh Yigit
2017-12-08 18:04 ` Stephen Hemminger
2017-12-08 18:22 ` Andrew Rybchenko
2017-12-11 5:27 ` Hemant Agrawal
2017-12-11 8:58 ` Olivier MATZ
2017-12-11 17:56 ` Ferruh Yigit
2017-12-12 16:57 ` Olivier MATZ
2017-12-13 5:13 ` Hemant Agrawal [this message]
2017-12-14 11:33 ` Hemant Agrawal
2017-12-14 12:58 ` Thomas Monjalon
2017-12-15 10:54 ` Hemant Agrawal
2017-12-22 15:59 ` [dpdk-dev] [PATCH v2] " Olivier Matz
2017-12-28 11:42 ` Hemant Agrawal
2018-01-05 10:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1018d643-eb39-cd23-4094-9ae2a4bcd860@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).