From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Alejandro Lucero <alejandro.lucero@netronome.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v9 1/9] nfp: basic initialization
Date: Fri, 27 Nov 2015 10:18:46 +0100 [thread overview]
Message-ID: <10228066.9OLyZAk2qB@xps13> (raw)
In-Reply-To: <CAD+H990Giq_7rbd-7mXoaQQiasii3MQv9R-zBstBPqgtNAPmpw@mail.gmail.com>
2015-11-27 07:51, Alejandro Lucero:
> I converted (almost) all the Linux typedefs. This one went under the radar.
>
> We do not have such thing like ixgbe/base but maybe it makes sense.
>
> Should I send a new patchset version for fixing this "minor nit"?
If you send a new version, please fix the MAINTAINERS file update
(and squash the change with the doc patch).
PS: please answer below instead of top post.
> On Thu, Nov 26, 2015 at 6:14 PM, Stephen Hemminger <
> stephen@networkplumber.org> wrote:
>
> > On Thu, 26 Nov 2015 09:49:21 +0000
> > Alejandro Lucero <alejandro.lucero@netronome.com> wrote:
> >
> > > +static inline void
> > > +nfp_qcp_ptr_add(__u8 *q, enum nfp_qcp_ptr ptr, uint32_t val)
> > > +{
> > > + uint32_t off;
> >
> > Minor nit. why mix use of Linux specific basic size typedefs (__u8)
> > with Posix standard values (uint32_t). The DPDK style is to use
> > the Posix types except in kernel drivers or code that is coming
> > from unified drivers (ie ixgbe/base)
> >
next prev parent reply other threads:[~2015-11-27 9:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 9:49 [dpdk-dev] [PATCH v9 0/9] support for netronome nfp-6xxx card Alejandro Lucero
2015-11-26 9:49 ` [dpdk-dev] [PATCH v9 1/9] nfp: basic initialization Alejandro Lucero
2015-11-26 18:14 ` Stephen Hemminger
2015-11-27 7:51 ` Alejandro Lucero
2015-11-27 9:18 ` Thomas Monjalon [this message]
2015-11-26 9:49 ` [dpdk-dev] [PATCH v9 2/9] nfp: adding rx/tx functionality Alejandro Lucero
2015-11-26 9:49 ` [dpdk-dev] [PATCH v9 3/9] nfp: adding rss Alejandro Lucero
2015-11-26 9:49 ` [dpdk-dev] [PATCH v9 4/9] nfp: adding stats Alejandro Lucero
2015-11-26 9:49 ` [dpdk-dev] [PATCH v9 5/9] nfp: adding link functionality Alejandro Lucero
2015-11-26 9:49 ` [dpdk-dev] [PATCH v9 6/9] nfp: adding extra functionality Alejandro Lucero
2015-11-26 9:49 ` [dpdk-dev] [PATCH v9 7/9] nfp: link status change interrupt support Alejandro Lucero
2015-11-26 9:49 ` [dpdk-dev] [PATCH v9 8/9] nfp: adding nic guide Alejandro Lucero
2015-11-26 9:49 ` [dpdk-dev] [PATCH v9 9/9] nfp: updating maintainers Alejandro Lucero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10228066.9OLyZAk2qB@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).