From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id D493A5A31 for ; Fri, 27 Nov 2015 10:20:05 +0100 (CET) Received: by wmvv187 with SMTP id v187so61856608wmv.1 for ; Fri, 27 Nov 2015 01:20:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=+Ms46NhqTjfXyTCMbugw7bOO8I2U0XkXRfvdUKHO5iM=; b=gQOcZ3YnqMcSsXkWKr6IjTbP0zeB1aTZN1egOdetVttr9pTzjWk4Ibmu/avycxrGmn QOnRxpE9eN5RDc3vOqdawvYWp/NDkgEpR2R+aejDD6M35YECCAN17JrhoHx1RW/3Hlnj k7bIWkUl6XiBW1cGEY+ttOnguxRJ/zIxesvKV8/TPuD0YMaXVgluhyMA/+v9LeqSsuvJ PRoxM4bCsrlnds2F9XIObwiSjYMJy4R1QSvK3P5oCOBih2/f7xU7Fklb8+dpDE0LocAe rF18I5HNgHsyK57/svgbo4UWOTMQLGzpOLpZtcJd2wJ4UAWS4v7OWff44thc9feV8n0S A1qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=+Ms46NhqTjfXyTCMbugw7bOO8I2U0XkXRfvdUKHO5iM=; b=GV0ighVZftyXbUD1tlmKuV+pLV5x7yI2aiveHdeRqv2YHqa0km910U5BlgmWnD+/UA y6uamJd6trZDg4vgxc2ArlsxM+KEcs1Bx4ToV1lYB2gfGoNaJg/XpKCq2QMpFBwtRntu xb2r/LEd9ncEHEKjz7Gbih9TdH0/pFpoOuqalVbJbDlUG1V601l8+52qGf3CkmEz6XnU EVXF2xwYGFYfVcpjWYN2UhBXe7Qs9kpAqyg4pWBd64k5F7bgNYsjWWG5jdBM2kCx9FJU Qv2Asl1HOV6SuWMuom2lQlHxT5RvTsZaydGMXz3A9JebrUBp/q1zdGsumB8muCGT1JkW NlHA== X-Gm-Message-State: ALoCoQltRVTUFdCkBDrD4wBpXw54VdRr7igg8dppocOpnFDOOCjUD9mLU0UA31yBEo2bMMGW0A6N X-Received: by 10.194.6.40 with SMTP id x8mr53897954wjx.50.1448616005695; Fri, 27 Nov 2015 01:20:05 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id jo6sm31920480wjb.48.2015.11.27.01.20.04 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 27 Nov 2015 01:20:05 -0800 (PST) From: Thomas Monjalon To: Alejandro Lucero Date: Fri, 27 Nov 2015 10:18:46 +0100 Message-ID: <10228066.9OLyZAk2qB@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1448531369-8808-1-git-send-email-alejandro.lucero@netronome.com> <20151126101449.3f450a14@xeon-e3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v9 1/9] nfp: basic initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2015 09:20:06 -0000 2015-11-27 07:51, Alejandro Lucero: > I converted (almost) all the Linux typedefs. This one went under the radar. > > We do not have such thing like ixgbe/base but maybe it makes sense. > > Should I send a new patchset version for fixing this "minor nit"? If you send a new version, please fix the MAINTAINERS file update (and squash the change with the doc patch). PS: please answer below instead of top post. > On Thu, Nov 26, 2015 at 6:14 PM, Stephen Hemminger < > stephen@networkplumber.org> wrote: > > > On Thu, 26 Nov 2015 09:49:21 +0000 > > Alejandro Lucero wrote: > > > > > +static inline void > > > +nfp_qcp_ptr_add(__u8 *q, enum nfp_qcp_ptr ptr, uint32_t val) > > > +{ > > > + uint32_t off; > > > > Minor nit. why mix use of Linux specific basic size typedefs (__u8) > > with Posix standard values (uint32_t). The DPDK style is to use > > the Posix types except in kernel drivers or code that is coming > > from unified drivers (ie ixgbe/base) > >