From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DF1FA0032; Tue, 12 Jul 2022 11:16:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 94EDB41109; Tue, 12 Jul 2022 11:16:25 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 07865410EF for ; Tue, 12 Jul 2022 11:16:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657617383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v8IPJ5GXKj1fFfrbsbeRhmuTiRtFpZ9N7bepocGRzzo=; b=RwbNa0zBv62iaJn++7VobLJxqzHqC5RVD7wBRI0zZsXOWm57lF08aNHgUS4DfVZBHfb200 7CcK2xHuyBLXcv7fkHIX/maFb92XjX1UlPym1ZcL+ed92AK0Rpcc0bru5tHBTme3k4E7En JgLUgIC1899TMBrUr6dzxUSFCXc0OMI= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-643-YTjJvXkNPH6pSkozECCqHw-1; Tue, 12 Jul 2022 05:16:20 -0400 X-MC-Unique: YTjJvXkNPH6pSkozECCqHw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DBC783C10235; Tue, 12 Jul 2022 09:16:19 +0000 (UTC) Received: from [10.39.208.27] (unknown [10.39.208.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F11BA40B40C8; Tue, 12 Jul 2022 09:16:17 +0000 (UTC) Message-ID: <1022991b-c3e5-1b1f-f713-f4769e6ca4e5@redhat.com> Date: Tue, 12 Jul 2022 11:16:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] doc: announce transition to vDPA port close function To: Thomas Monjalon , dev@dpdk.org Cc: ferruh.yigit@intel.com, david.marchand@redhat.com, olivier.matz@6wind.com, andrew.rybchenko@oktetlabs.ru, chenbo.xia@intel.com, ktraynor@redhat.com, Ray Kinsella , Neil Horman References: <20210518073441.2749096-1-thomas@monjalon.net> From: Maxime Coquelin In-Reply-To: <20210518073441.2749096-1-thomas@monjalon.net> X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/18/21 09:34, Thomas Monjalon wrote: > There is a layer violation in the vDPA API which encourages to destroy > a full device with rte_dev_remove() instead of just closing the port. > The plan is to introduce a new function in 21.08, promote in 21.11, > and deprecate rte_vdpa_get_rte_device() in 21.11. > > Signed-off-by: Thomas Monjalon > --- > doc/guides/rel_notes/deprecation.rst | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 9584d6bfd7..30f84403eb 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -126,6 +126,14 @@ Deprecation Notices > can still be used if users specify the devarg "driver=i40evf". I40evf will > be deleted in DPDK 21.11. > > +* vdpa: The vDPA API should not try to manipulate or export > + any ``rte_device`` object, which belongs to the bus layer. > + The function ``rte_vdpa_get_rte_device()`` will be deprecated in 21.11, > + when its usage will be replaced with a function ``rte_vdpa_close()``. > + The new function should enter in 21.08 and get promoted to stable in 21.11. > + A port close function will allow to close a single port without destroying > + the rest of the device. > + > * eventdev: The structure ``rte_event_eth_rx_adapter_queue_conf`` will be > extended to include ``rte_event_eth_rx_adapter_event_vector_config`` elements > and the function ``rte_event_eth_rx_adapter_queue_event_vector_config`` will Maybe there was some changes since you posted the announce, but I don't see why rte_vdpa_close() would be needed. It seems the only user of rte_vdpa_get_rte_device() is the internal vDPA example, and it only use it to get and print the device name. Thanks, Maxime