From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02DF745C0A; Tue, 29 Oct 2024 12:51:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA52F4014F; Tue, 29 Oct 2024 12:51:19 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 2925A40144 for ; Tue, 29 Oct 2024 12:51:18 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 09C9513D5; Tue, 29 Oct 2024 04:51:47 -0700 (PDT) Received: from [10.57.58.134] (unknown [10.57.58.134]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AD8DD3F73B; Tue, 29 Oct 2024 04:51:16 -0700 (PDT) Message-ID: <10231179-6491-4d64-b831-7c47393590ff@arm.com> Date: Tue, 29 Oct 2024 11:51:15 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/7] dts: remove git ref option Content-Language: en-GB To: Patrick Robb Cc: dev@dpdk.org, Paul Szczepanek , =?UTF-8?B?VG9tw6HFoSDEjnVyb3ZlYw==?= References: <20240930160204.19582-1-tomas.durovec@pantheon.tech> <20241021134935.1210500-1-luca.vizzarro@arm.com> <20241021134935.1210500-8-luca.vizzarro@arm.com> From: Luca Vizzarro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Patrick, On 29/10/2024 01:28, Patrick Robb wrote: > -Example command for running DTS with the template configuration and > DPDK tag v23.11: > - > -.. code-block:: console > - > -   (dts-py3.10) $ ./main.py --git-ref v23.11 > - > > > I see this needs to go because of the --git-ref usage. Can this be > replaced with a new example command? Perhaps even 2, one for each of -- > tarball and --dpdk-tree? These patches make these command line arguments optional, and instead of being the primary source of DPDK, they become overrides of the configuration fields. The original doc snippet was there as it was mandatory to make it work, but it's no longer the case given the configuration must be completed or DTS won't run. And naturall with a completed configuration there is no further need to use CLI arguments. Hope this clarifies! Best, Luca