From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id B10E629CD for ; Wed, 30 Mar 2016 19:14:36 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id p65so192182133wmp.1 for ; Wed, 30 Mar 2016 10:14:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=IcUsT/9hBaTK92e2mktR/AQQ3x8bp6cwv9qKGWYK6FM=; b=dHJ+OzXidTScsa5sdoCKG4DujhI1KyK+a/iHV0wJFLrG3jloyWbQsjxeFAePwyczbJ X6f1AgEYu6mSQprzBsFzdxtDvSYIjNBHZ8JsOq2kW8FrqY2YJhV39XESVEupwl8cHHxd qzzjiqbcsizikkGGx1fJzG5XygcHD6rb2cIfNUCGXgHc2O0Nv0gkIB0DXvATUSIwCPPj Z3BrI2Qu+GlU5uhy9SMGIMgtfTYUW/ZEJOSl5zwub4Redaha2Ol/+tLQfwPCwKk5Aeht JUMKE4KH4eXgVqlN6+Ky3LrI6s4au7K0C/CIYOA+XsYrvwZPy0hwHTQZbZL2tMvluRy6 7rOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=IcUsT/9hBaTK92e2mktR/AQQ3x8bp6cwv9qKGWYK6FM=; b=KR/oIdhSmBrpp+BbWGL/7EP58eidvaBhJvx1ZG8oB+7IhilXlrzZIvTHyIC06TX5S6 RZfAJfp4wJDAOS15kBGyjizlr91oe59aK6J43XxyS+jJN+k1KEyVtkVOHZfEAaPifYMG h3Aqu2x7JIzIn451dAPHu1Z86ZHvRAzMRoCTwAaR74W3oR6+BftUM/d/joD9nTipmJXP sEq7Kd/xtrclDSiZS3GVmb6/9Iz3M3nSRyDZBts3n8EZlirZEhGc+pL8RidgfoXCW8hw zoGkOsdT0WZW1m1Cd122o6ZgBQed7DKN8qfWD0Q5X1OxzCW1G0qXI6n60BfD7Kz5/E7B mKHg== X-Gm-Message-State: AD7BkJJiZ25Sb/flkJHyjEVs50njXprVRgHlh7O84mmp4hWloPG8gOUJCeFHABFgkDn6HNTm X-Received: by 10.28.65.137 with SMTP id o131mr11973776wma.54.1459358076462; Wed, 30 Mar 2016 10:14:36 -0700 (PDT) Received: from xps13.localnet (233.202.154.77.rev.sfr.net. [77.154.202.233]) by smtp.gmail.com with ESMTPSA id e80sm6913726wma.1.2016.03.30.10.14.34 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 30 Mar 2016 10:14:35 -0700 (PDT) From: Thomas Monjalon To: Stephen Hemminger Cc: Aaron Conole , Panu Matilainen , "Lu, Wenzhuo" , dev@dpdk.org, "Richardson, Bruce" Date: Wed, 30 Mar 2016 19:12:39 +0200 Message-ID: <10236988.vM3noimEBN@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160330093653.0d7e1847@xeon-e3> References: <1458682638-28378-1-git-send-email-aconole@redhat.com> <20160330093653.0d7e1847@xeon-e3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 2/7] drivers/net/e1000: Suppress misleading indentation warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2016 17:14:36 -0000 2016-03-30 09:36, Stephen Hemminger: > On Wed, 30 Mar 2016 10:06:36 -0400 > Aaron Conole wrote: > > --- a/drivers/net/e1000/Makefile > > +++ b/drivers/net/e1000/Makefile > > @@ -54,6 +54,9 @@ else > > # > > CFLAGS_BASE_DRIVER = -Wno-uninitialized -Wno-unused-parameter > > CFLAGS_BASE_DRIVER += -Wno-unused-variable > > +ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1) > > +CFLAGS_BASE_DRIVER += -Wno-misleading-indentation > > +endif > > endif > > NAK, don't do it to the whole file. > Fix the code (best option) > or use a pragma for the small area which is broken for other reasons. Stephen, your solutions do not work because Aaron has not been allowed to modify this file. As long as we are not allowed to modify the Intel base drivers, I don't see any problem to hide some warnings in them. The warnings could help us to clean the code or fix some bugs but we are not allowed to... It is the responsibility of the driver maintainer to keep this nasty code.