DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: olivier.matz@6wind.com, stable@dpdk.org,
	Ali Alnubani <alialnu@mellanox.com>,
	David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2] devtools: remove config backup after test build setup
Date: Mon, 25 May 2020 00:02:10 +0200	[thread overview]
Message-ID: <10261573.qCmUbjIAlI@thomas> (raw)
In-Reply-To: <20191216191553.1997116-1-thomas@monjalon.net>

16/12/2019 20:15, Thomas Monjalon:
> The config options are updated with sed and the short in-place option.
> In order to avoid creating a backup file when using sed in-place,
> the argument was tentatively set as an empty suffix.
> On Linux, the suffix argument is optional, without space or equal before.
> On FreeBSD, the suffix argument of the in-place option is mandatory.
> This argument cannot be an empty string if no space before.
> In GNU sed, the short option '-i' does not expect '=' before the suffix
> argument, so it understands '=' as the file suffix.
> As a consequence, a backup file named '.config=' was created
> on Linux in the build directory.
> There is no common solution (without creating a function)
> to skip the backup file with GNU sed and BSD sed.
> It is solved by always creating a .config.tmp backup file
> which is removed at the end of the configuration.
> Fixes: 4a4a20c4775b ("devtools: support FreeBSD")
> Cc: olivier.matz@6wind.com
> Cc: stable@dpdk.org
> Reported-by: Ali Alnubani <alialnu@mellanox.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v1: try removing = sign
> v2: do not skip backup file
> ---
>  devtools/test-build.sh | 78 ++++++++++++++++++++++--------------------
>  1 file changed, 40 insertions(+), 38 deletions(-)

This file should be removed in 20.11 when dropping make support.
No need for this short-live half-fix.
Marked as rejected.

      reply	other threads:[~2020-05-24 22:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16 16:22 [dpdk-dev] [PATCH] devtools: avoid config backup during " Thomas Monjalon
2019-12-16 16:40 ` Bruce Richardson
2019-12-16 16:47   ` Thomas Monjalon
2019-12-16 16:59     ` Bruce Richardson
2019-12-16 17:45       ` Thomas Monjalon
2019-12-16 19:15 ` [dpdk-dev] [PATCH v2] devtools: remove config backup after " Thomas Monjalon
2020-05-24 22:02   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10261573.qCmUbjIAlI@thomas \
    --to=thomas@monjalon.net \
    --cc=alialnu@mellanox.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).