From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CA67A04BC; Fri, 9 Oct 2020 21:15:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0CBE41C2F3; Fri, 9 Oct 2020 21:15:57 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 306C31C227 for ; Fri, 9 Oct 2020 21:15:55 +0200 (CEST) IronPort-SDR: irg7BcKnzdZHTBitcpSaWCc8aLkF26KdY0o8PHo1sNnOfHW9qv/4VtYK0OzxFCcF1KfDO2WIbk BDnvC1XPDRRw== X-IronPort-AV: E=McAfee;i="6000,8403,9769"; a="144847693" X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="144847693" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 12:15:52 -0700 IronPort-SDR: j/fQCYwRaHq28MvwSJJOV7Z0hhqC5mRcufFefggKCVTwAtaeP7PSoTenjs4j5Pta0jQrP7hQNg UcDOU9EA/PbA== X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="462295027" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.18.7]) ([10.252.18.7]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 12:15:50 -0700 To: Kevin Laatz , Thomas Monjalon , dev@dpdk.org, Harry van Haaren , Ciara Power Cc: arybchenko@solarflare.com, David Marchand , Maryam Tahhan References: <20201007214848.249516-1-thomas@monjalon.net> <1855125c-01f2-8bc2-be73-6a3c29587476@intel.com> From: Ferruh Yigit Message-ID: <10289a7a-e410-67d8-c0bf-5b053869aac0@intel.com> Date: Fri, 9 Oct 2020 20:15:46 +0100 MIME-Version: 1.0 In-Reply-To: <1855125c-01f2-8bc2-be73-6a3c29587476@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] ethdev: fix xstat name of basic stats per queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/9/2020 5:53 PM, Kevin Laatz wrote: > > On 08/10/2020 16:41, Ferruh Yigit wrote: >> On 10/7/2020 10:48 PM, Thomas Monjalon wrote: >>> As described in doc/guides/prog_guide/poll_mode_drv.rst, >>> the naming scheme for the xstats is parts separated with underscore: >>>     * direction >>>     * detail 1 >>>     * detail 2 >>>     * detail n >>>     * unit >>> where detail 1 can be "q" followed with a queue number. >>> It means the name of the stats per queue should be rx_qN_* or tx_qN_*. >>> >>> The second underscore was missing so far. >>> Fixing the basic xstat names may be considered an API change, >>> that's why it should not be backported. >>> >>> While fixing this mistake, some examples of the naming scheme >>> are given as part of the API documentation of rte_eth_xstat_name. >>> More proposals about standardizing statistics: >>>     http://fast.dpdk.org/events/slides/DPDK-2019-09-Ethernet_Statistics.pdf >>> >>> Fixes: bd6aa172cf35 ("ethdev: fetch extended statistics with integer ids") >>> >>> Signed-off-by: Thomas Monjalon >> >> no objection, >> Reviewed-by: Ferruh Yigit >> >>>   doc/guides/rel_notes/release_20_11.rst | 8 +++++++- >>>   lib/librte_ethdev/rte_ethdev.c         | 4 ++-- >>>   lib/librte_ethdev/rte_ethdev.h         | 7 +++++++ >>>   3 files changed, 16 insertions(+), 3 deletions(-) >>> >>> diff --git a/doc/guides/rel_notes/release_20_11.rst >>> b/doc/guides/rel_notes/release_20_11.rst >>> index cdf20404c9..d0d77c5d3d 100644 >>> --- a/doc/guides/rel_notes/release_20_11.rst >>> +++ b/doc/guides/rel_notes/release_20_11.rst >>> @@ -200,7 +200,13 @@ API Changes >>>     * ethdev: ``rte_eth_rx_descriptor_done()`` API has been deprecated. >>>   -* Renamed internal ethdev APIs: >>> +* ethdev: Renamed basic statistics per queue. An underscore is inserted >>> +  between the queue number and the rest of the xstat name: >>> + >>> +  * ``rx_qN*`` -> ``rx_qN_*`` >>> +  * ``tx_qN*`` -> ``tx_qN_*`` >>> + >> >> As far as I remember collect plugin was using xstat output, does this rename >> affects it? Or any other telemetry application relying on xstats. >> >> Harry, Ciara, Kevin, do you know anything that will be affected from rename? > > Looks to me like everything will be ok in the old collectd plugins too - from > doing a code review, it seems it just gets the names from ethdev. > Thanks for checking, the workaround David highlighted in the collectd seems preventing this change to cause an error, so we can proceed. But it would be nice to test the 'dpdkstat' plugin with this change. Do you know who is the maintainer of that plugin in collectd?