From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 75DE51B1EA for ; Mon, 14 Jan 2019 16:28:51 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 120A52DDEB; Mon, 14 Jan 2019 10:28:51 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 14 Jan 2019 10:28:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=tSLql50NKgAy8sNRVPjrdNLFjKzcsQkvPcrTv7vblSA=; b=j2t4+LF+fD2F FhIIzljnfChyEyd89IZuRPDuCYhAi+/gZG6pNlDaa1FswesHbcq6TRyTxrXiVPZL 6kStdPuDkd3q1giYOGFzeH0pGzCe16YjVy5NRYecq6JlC8GJbl6EMFMlV9QJ1IlK NVViksco8O1h37a4kZmStJMEGIZScFE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=tSLql50NKgAy8sNRVPjrdNLFjKzcsQkvPcrTv7vbl SA=; b=AQ9qOTZoF4sqtrqBulTVsvhBSdENldegQQyf8/i6Jdy/HUuuZyou4x5gm lvcv1Ot3413DDubiWmySw2bYxx9Ys48AFG8PkBsfwyHzO+PeareAuCYcCJQa031b g+KZPbN8Or2D4GT5+J7uWTEvarF63W4Tc/WWJFO/M3x+vBST03t/ts/eOCXCME1I vCB+P6UptCLHEfkBeocPw/71yzyoBW5TzN2lmd+6JRyBZj0kz0uRh4vEb9j37nUk s1x6QmI/BOoAeHrKALf0C8Aqzp5yHzonWj6ZMnXEZaYnkYQq0vhd/F8Uw0qFZR0t 4Q2T8/qu5tzk6XOt6kV8FWqlpZurw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgedugdejjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfe drudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 36B4EE465D; Mon, 14 Jan 2019 10:28:49 -0500 (EST) From: Thomas Monjalon To: "Van Haaren, Harry" Cc: dev@dpdk.org, Olivier Matz , "Dumitrescu, Cristian" , "Pattan, Reshma" , "stephen@networkplumber.org" , "gavin.hu@arm.com" , "honnappa.nagarahalli@arm.com" Date: Mon, 14 Jan 2019 16:28:48 +0100 Message-ID: <103174099.zUeztqKWy2@xps> In-Reply-To: <20190114145838.lqdq3c5y23wsr3hq@platinum> References: <20190110180658.23302-1-harry.van.haaren@intel.com> <3EB4FA525960D640B5BDFFD6A3D891268E82929F@IRSMSX108.ger.corp.intel.com> <20190114145838.lqdq3c5y23wsr3hq@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] mbuf: fix compile by making sched struct visible X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 15:28:51 -0000 14/01/2019 15:58, Olivier Matz: > On Fri, Jan 11, 2019 at 02:33:16PM +0000, Dumitrescu, Cristian wrote: > > From: Van Haaren, Harry > > > > > > Although C compilation works with the struct rte_mbuf_sched > > > declared inside the struct rte_mbuf namespace, C++ fails to > > > compile. This fix moves the rte_mbuf_sched struct up to the > > > global namespace, instead of declaring it inside the struct > > > mbuf namespace. > > > > > > The struct rte_mbuf_sched is being used on the stack in > > > rte_mbuf_sched_get() and as a cast in _set(). For this > > > reason, it must be exposed as an available type. > > > > > > Fixes: 5d3f72100904 ("mbuf: implement generic format for sched field") > > > > > > Signed-off-by: Harry van Haaren > > > > > > --- > > > > > > v3: > > > - Update comment in mbuf to state size of struct sched (Crisitian) > > > > > > v2: > > > - Different solution, not applicable, v3 based on v1 (ML discussion) > > > > Acked-by: Cristian Dumitrescu > > > > Of course, final say belongs to Olivier, so Olivier please let un know your vote. > > Acked-by: Olivier Matz Applied, thanks