* [dpdk-dev] [PATCH 0/2] fix missing dependencies
@ 2015-12-02 4:05 Stephen Hemminger
2015-12-02 4:05 ` [dpdk-dev] [PATCH 1/2] cmdline_test: add " Stephen Hemminger
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Stephen Hemminger @ 2015-12-02 4:05 UTC (permalink / raw)
To: dev
Fix some issues found when doing parallel builds
Stephen Hemminger (2):
cmdline_test: add missing dependencies
bonding: add depencency on cmdline library
app/cmdline_test/Makefile | 3 +++
drivers/net/bonding/Makefile | 1 +
2 files changed, 4 insertions(+)
--
2.1.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH 1/2] cmdline_test: add missing dependencies
2015-12-02 4:05 [dpdk-dev] [PATCH 0/2] fix missing dependencies Stephen Hemminger
@ 2015-12-02 4:05 ` Stephen Hemminger
2015-12-02 4:05 ` [dpdk-dev] [PATCH 2/2] bonding: add depencency on cmdline library Stephen Hemminger
2015-12-02 17:09 ` [dpdk-dev] [PATCH 0/2] fix missing dependencies Declan Doherty
2 siblings, 0 replies; 5+ messages in thread
From: Stephen Hemminger @ 2015-12-02 4:05 UTC (permalink / raw)
To: dev
The cmdline test is missing a necessary dependency on other components.
This caused a build failure when doing parallel builds.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
app/cmdline_test/Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/app/cmdline_test/Makefile b/app/cmdline_test/Makefile
index e9eafd2..c6169f5 100644
--- a/app/cmdline_test/Makefile
+++ b/app/cmdline_test/Makefile
@@ -47,6 +47,9 @@ SRCS-y += commands.c
CFLAGS += -O3
CFLAGS += $(WERROR_FLAGS)
+# this application needs libraries first
+DEPDIRS-y += lib drivers
+
include $(RTE_SDK)/mk/rte.app.mk
endif
--
2.1.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH 2/2] bonding: add depencency on cmdline library
2015-12-02 4:05 [dpdk-dev] [PATCH 0/2] fix missing dependencies Stephen Hemminger
2015-12-02 4:05 ` [dpdk-dev] [PATCH 1/2] cmdline_test: add " Stephen Hemminger
@ 2015-12-02 4:05 ` Stephen Hemminger
2015-12-02 17:09 ` [dpdk-dev] [PATCH 0/2] fix missing dependencies Declan Doherty
2 siblings, 0 replies; 5+ messages in thread
From: Stephen Hemminger @ 2015-12-02 4:05 UTC (permalink / raw)
To: dev
Parallel build of bonding driver can fail because of
missing dependency.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/bonding/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/bonding/Makefile b/drivers/net/bonding/Makefile
index dee0875..10c794c 100644
--- a/drivers/net/bonding/Makefile
+++ b/drivers/net/bonding/Makefile
@@ -63,5 +63,6 @@ DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += lib/librte_mbuf
DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += lib/librte_ether
DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += lib/librte_eal
DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += lib/librte_kvargs
+DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += lib/librte_cmdline
include $(RTE_SDK)/mk/rte.lib.mk
--
2.1.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH 0/2] fix missing dependencies
2015-12-02 4:05 [dpdk-dev] [PATCH 0/2] fix missing dependencies Stephen Hemminger
2015-12-02 4:05 ` [dpdk-dev] [PATCH 1/2] cmdline_test: add " Stephen Hemminger
2015-12-02 4:05 ` [dpdk-dev] [PATCH 2/2] bonding: add depencency on cmdline library Stephen Hemminger
@ 2015-12-02 17:09 ` Declan Doherty
2015-12-02 22:58 ` Thomas Monjalon
2 siblings, 1 reply; 5+ messages in thread
From: Declan Doherty @ 2015-12-02 17:09 UTC (permalink / raw)
To: Stephen Hemminger, dev
On 02/12/15 04:05, Stephen Hemminger wrote:
> Fix some issues found when doing parallel builds
>
> Stephen Hemminger (2):
> cmdline_test: add missing dependencies
> bonding: add depencency on cmdline library
>
> app/cmdline_test/Makefile | 3 +++
> drivers/net/bonding/Makefile | 1 +
> 2 files changed, 4 insertions(+)
>
Series Acked-by: Declan Doherty<declan.doherty@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH 0/2] fix missing dependencies
2015-12-02 17:09 ` [dpdk-dev] [PATCH 0/2] fix missing dependencies Declan Doherty
@ 2015-12-02 22:58 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2015-12-02 22:58 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
2015-12-02 17:09, Declan Doherty:
> On 02/12/15 04:05, Stephen Hemminger wrote:
> > Fix some issues found when doing parallel builds
> >
> > Stephen Hemminger (2):
> > cmdline_test: add missing dependencies
> > bonding: add depencency on cmdline library
> >
> > app/cmdline_test/Makefile | 3 +++
> > drivers/net/bonding/Makefile | 1 +
> > 2 files changed, 4 insertions(+)
> >
> Series Acked-by: Declan Doherty<declan.doherty@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-12-02 23:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-02 4:05 [dpdk-dev] [PATCH 0/2] fix missing dependencies Stephen Hemminger
2015-12-02 4:05 ` [dpdk-dev] [PATCH 1/2] cmdline_test: add " Stephen Hemminger
2015-12-02 4:05 ` [dpdk-dev] [PATCH 2/2] bonding: add depencency on cmdline library Stephen Hemminger
2015-12-02 17:09 ` [dpdk-dev] [PATCH 0/2] fix missing dependencies Declan Doherty
2015-12-02 22:58 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).