From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com
 [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 8315AC4C2
 for <dev@dpdk.org>; Wed, 17 Jun 2015 23:30:51 +0200 (CEST)
Received: by wibdq8 with SMTP id dq8so67825783wib.1
 for <dev@dpdk.org>; Wed, 17 Jun 2015 14:30:51 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=fHdMqNMFBJm9WQw1TZRqH352IHtG0a6ZYqt1Nt75E24=;
 b=etQdXYcD8Nx2dmMfOOt45B+oSPVTSC4axm7KVoGwAmCUNkEm7KUD/oK9FPOrWMY15i
 S+xIAJ3si0RSPi5xa5i8v8ugfDDCVO7LqVz/StLuX/Zmf3elx69v3tuMnb2Pwk9LwtlK
 2JkE0esgBXX0NwVrMY2y93rHG5piHqmZeyReZtmPzxaPWT+ooGdDhjL2ekQyUfaTv04r
 icfhrb0rEvNul4R+dV6PLv7GhSF5Teefg5qWhFVVvUPrA4BWRIxRfT9VxcnH9IeBsNFQ
 2WdswEP/77Xe6ZI43JfIYelJGMzivt6FCyAsTu/g8QDmXEx4MXfDSN0kqZmVoZbziLTB
 YwwQ==
X-Gm-Message-State: ALoCoQlr2J++xXEQu0tpA8Lf3kdhGFj11I3F5AuOvod/Q5Zvth9S0NqvRjqXqj3YZ+w0J1puHhti
X-Received: by 10.194.121.163 with SMTP id ll3mr9299196wjb.142.1434576651127; 
 Wed, 17 Jun 2015 14:30:51 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id ef10sm8856681wjd.49.2015.06.17.14.30.49
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 17 Jun 2015 14:30:50 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Roman Dementiev <roman.dementiev@intel.com>
Date: Wed, 17 Jun 2015 23:29:49 +0200
Message-ID: <10408699.ljKKKDUIsH@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1434475006-13732-2-git-send-email-roman.dementiev@intel.com>
References: <1433250693-23644-1-git-send-email-roman.dementiev@intel.com>
 <1434475006-13732-1-git-send-email-roman.dementiev@intel.com>
 <1434475006-13732-2-git-send-email-roman.dementiev@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/3] spinlock: add support for HTM lock
	elision for x86
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jun 2015 21:30:51 -0000

2015-06-16 10:16, Roman Dementiev:
> --- a/lib/librte_eal/common/include/arch/x86/rte_spinlock.h
> +++ b/lib/librte_eal/common/include/arch/x86/rte_spinlock.h
> @@ -39,6 +39,13 @@ extern "C" {
>  #endif
>  
>  #include "generic/rte_spinlock.h"
> +#include "rte_rtm.h"
> +#include "rte_cpuflags.h"
> +#include "rte_branch_prediction.h"
> +#include <rte_common.h>

Why using angle brackets for rte_common.h?

Introducing rte_cpuflags.h in this header breaks the compilation of
the mlx4 pmd with CONFIG_RTE_LIBRTE_MLX4_DEBUG=y.
Indeed, it triggers the -pedantic flag which is not supported by rte_cpuflags.h.
Maybe it's time to fix this header?