From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 71EAE677C for ; Wed, 2 Mar 2016 17:13:37 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id l68so84829409wml.1 for ; Wed, 02 Mar 2016 08:13:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=CkLsnP0Gim5RNB/9wToafMxufK4dXIIwdhVtR/QgN2I=; b=pLUbOGIkKWift7xAx/1cS4PPOLmlcochsRd7UOoLaBqVGLyoxiamhP2dBcPtuR8kDX wIZLZMyYGTpdw9BDTDGZEju5HVPrXs+LIMd1InsJIFr2GkZr93ZHYpckg7rQn4WGqwTw dlgeKktqOzBzz13wveT2dNA2CBmr/QVXKMX5wQmV0kNVOrRZmmsl+jm+stiCj+QapdKO SVspkzdtXdX2RjN0gYnGVPz0verO4GDrtbbj74hMQDHzABkDK/HEeaDc3YvEEiw/v4Os K67YRf9RMHPgOho6ssqEOEqom7bcUKoxHE/FUkQbYcfZ6bSYP5hYNHoskI4Jqh0jl3pP sRNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=CkLsnP0Gim5RNB/9wToafMxufK4dXIIwdhVtR/QgN2I=; b=YGL3ab56+GjIAODnfkH1HjQjC0Cz3e0YAFJl2/CFY+R5TqYmjb8W/d6Dk6c4D3CrDz RZ4eg+NTdwA68stTzmIuAW6Tc2yf0hU4pbj8t6VDQzMnObgm+5DM/EkQmnOWX2r7CQKf 5wsf6WSV2evSntVAXKxmH+YPem9KPaS8jml46GGKU3b98thfQ/oC9ZRYER80DkqsYP52 IYZOT7BPJlCf2UkmHYvh8yIakSKNbY69dPK7QzqEdvaBxCOOFz0qLUqa6oFx1IYE2qHP X+Pz2iLUibwk8Cy0f4uQ96K0ArDPUP7Jjn1PLUn0fnuFc+hbCeGXeuxWy3zZEGlaMQ5C CBqQ== X-Gm-Message-State: AD7BkJI74v2M8UfOhZSNZdMUWZpWqW8zzHYxtq5CwHHDiNsOOCf3jAYlRYuzt82YSiekiGks X-Received: by 10.28.32.13 with SMTP id g13mr723629wmg.13.1456935216324; Wed, 02 Mar 2016 08:13:36 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id s206sm3309231wmf.23.2016.03.02.08.13.35 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 02 Mar 2016 08:13:35 -0800 (PST) Date: Wed, 02 Mar 2016 08:13:35 -0800 (PST) X-Google-Original-Date: Wed, 02 Mar 2016 17:12 +0100 From: Thomas Monjalon To: Ralf Hoffmann Message-ID: <10430327.MBS0Qdx8Wk@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1452178442-22154-1-git-send-email-ralf.hoffmann@allegro-packets.com> References: <568E77F3.8070408@intel.com> <1452178442-22154-1-git-send-email-ralf.hoffmann@allegro-packets.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 1/1] eal/linux: change hugepage sorting to avoid overlapping memcpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2016 16:13:38 -0000 2016-01-07 15:54, Ralf Hoffmann: > with only one hugepage or already sorted hugepage addresses, the sort > function called memcpy with same src and dst pointer. Debugging with > valgrind will issue a warning about overlapping area. This patch changes > the sort method to qsort to avoid this behavior. The separate sort > function is no longer necessary. > > Signed-off-by: Ralf Hoffmann > Acked-by: Sergio Gonzalez Monroy Added ref to Jay Rolette and Applied, thanks