From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>, imustafin@bk.ru
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] RTE_PIPELINE_ACTION_PORT_META doesn't work properly
Date: Fri, 20 Feb 2015 21:47:04 +0100 [thread overview]
Message-ID: <10474963.UjXCaseS66@xps13> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891263231B304@IRSMSX108.ger.corp.intel.com>
2015-02-20 19:26, Dumitrescu, Cristian:
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of ?????? ????????
> > Sent: Friday, February 20, 2015 4:25 PM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] RTE_PIPELINE_ACTION_PORT_META doesn't work
> > properly
> >
> > Hi, list!
> >
> > RTE_PIPELINE_ACTION_PORT_META option in rte_pipeline library doesn't
> > work for non-default table entries. Is this bug or correct behaviour?
> >
> > This is my patch, that changes this behaviour:
> >
> > --- a/lib/librte_pipeline/rte_pipeline.c
> > +++ b/lib/librte_pipeline/rte_pipeline.c
> > @@ -999,8 +999,10 @@ rte_pipeline_compute_masks(struct rte_pipeline
> > *p, uint64_t pkts_mask)
> > {
> > p->action_mask1[RTE_PIPELINE_ACTION_DROP] = 0;
> > p->action_mask1[RTE_PIPELINE_ACTION_PORT] = 0;
> > + p->action_mask1[RTE_PIPELINE_ACTION_PORT_META] = 0;
> > p->action_mask1[RTE_PIPELINE_ACTION_TABLE] = 0;
> >
> > +
> > if ((pkts_mask & (pkts_mask + 1)) == 0) {
> > uint64_t n_pkts = __builtin_popcountll(pkts_mask);
> > uint32_t i;
> > @@ -1224,6 +1226,7 @@ rte_pipeline_run(struct rte_pipeline *p)
> > pkts_mask = RTE_LEN2MASK(n_pkts, uint64_t);
> > p->action_mask0[RTE_PIPELINE_ACTION_DROP] = 0;
> > p->action_mask0[RTE_PIPELINE_ACTION_PORT] = 0;
> > + p->action_mask0[RTE_PIPELINE_ACTION_PORT_META] = 0;
> > p->action_mask0[RTE_PIPELINE_ACTION_TABLE] = 0;
> >
> > /* Input port user actions */
> > @@ -1300,6 +1303,9 @@ rte_pipeline_run(struct rte_pipeline *p)
> > p->action_mask0[RTE_PIPELINE_ACTION_PORT] |=
> > p->action_mask1[
> > RTE_PIPELINE_ACTION_PORT];
> > + p->action_mask0[RTE_PIPELINE_ACTION_PORT_META] |=
> > + p->action_mask1[
> > + RTE_PIPELINE_ACTION_PORT_META];
> > p->action_mask0[RTE_PIPELINE_ACTION_TABLE] |=
> > p->action_mask1[
> > RTE_PIPELINE_ACTION_TABLE];
> >
> >
> >
> >
> >
> > Thanks, Ildar
>
> Acked by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
No Cristian, you cannot ack this patch, even if it fixes the problem.
The format is not OK: indent is wrong and it's not signed.
Please Ildar, check http://dpdk.org/dev#send to know how to submit a patch.
> Thank you, Ildar!
next prev parent reply other threads:[~2015-02-20 20:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 16:25 Ильдар Мустафин
2015-02-20 19:26 ` Dumitrescu, Cristian
2015-02-20 20:47 ` Thomas Monjalon [this message]
2015-02-20 20:55 ` Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10474963.UjXCaseS66@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=imustafin@bk.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).