From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 200FCB74B for ; Fri, 20 Feb 2015 21:47:35 +0100 (CET) Received: by mail-wg0-f45.google.com with SMTP id k14so15353413wgh.4 for ; Fri, 20 Feb 2015 12:47:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=8XioMhIj5bs0i/GhXSvXBcUWdtbrFgf/GiTDr4LHaQI=; b=XS7NBPOnG+MzHK6GiuYPgp22YiiASVDeKsPW+6iJxtLGg3pHd6aciK3Mu4JI0ol9Wa 3gG1gBE4TOez6GrIjKqQyIkUsIpfgDCpklmLZBdSYOx6fk2YqJuNT/ZSTq/VLd/x3Xra bpxJLs+I2F0mzkkyXKT28d2YQ1h6rQ85gVBVqv6FRk3D6UhTANGV5H5TeW5UCsDfKFsG f+5Iyc2rD/b7CRT2YWSzsLApes3XtQO/k6OOiT6zIjnvx87IOm84phoyV4tI1QfE9oGZ Q7PFio+4GLxMslokjfdg7Xag4s7h80dOQy5A59PLEZW6l5nL1xDE29UQwZ8fosRXblko M5Gg== X-Gm-Message-State: ALoCoQnbczbULPR0Uh3NxsXVo4hurYJiKTaIilD5AkEJ1ntObvDVABaLyNlIBhJaLOzEg1Qrf8KB X-Received: by 10.180.19.193 with SMTP id h1mr656262wie.2.1424465254950; Fri, 20 Feb 2015 12:47:34 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id di11sm3976162wid.8.2015.02.20.12.47.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Feb 2015 12:47:34 -0800 (PST) From: Thomas Monjalon To: "Dumitrescu, Cristian" , imustafin@bk.ru Date: Fri, 20 Feb 2015 21:47:04 +0100 Message-ID: <10474963.UjXCaseS66@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891263231B304@IRSMSX108.ger.corp.intel.com> References: <1424449505.129655495@f327.i.mail.ru> <3EB4FA525960D640B5BDFFD6A3D891263231B304@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] RTE_PIPELINE_ACTION_PORT_META doesn't work properly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 20:47:35 -0000 2015-02-20 19:26, Dumitrescu, Cristian: > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of ?????? ???????? > > Sent: Friday, February 20, 2015 4:25 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] RTE_PIPELINE_ACTION_PORT_META doesn't work > > properly > > > > Hi, list! > > > > RTE_PIPELINE_ACTION_PORT_META option in rte_pipeline library doesn't > > work for non-default table entries. Is this bug or correct behaviour? > > > > This is my patch, that changes this behaviour: > > > > --- a/lib/librte_pipeline/rte_pipeline.c > > +++ b/lib/librte_pipeline/rte_pipeline.c > > @@ -999,8 +999,10 @@ rte_pipeline_compute_masks(struct rte_pipeline > > *p, uint64_t pkts_mask) > > { > > p->action_mask1[RTE_PIPELINE_ACTION_DROP] = 0; > > p->action_mask1[RTE_PIPELINE_ACTION_PORT] = 0; > > + p->action_mask1[RTE_PIPELINE_ACTION_PORT_META] = 0; > > p->action_mask1[RTE_PIPELINE_ACTION_TABLE] = 0; > > > > + > > if ((pkts_mask & (pkts_mask + 1)) == 0) { > > uint64_t n_pkts = __builtin_popcountll(pkts_mask); > > uint32_t i; > > @@ -1224,6 +1226,7 @@ rte_pipeline_run(struct rte_pipeline *p) > > pkts_mask = RTE_LEN2MASK(n_pkts, uint64_t); > > p->action_mask0[RTE_PIPELINE_ACTION_DROP] = 0; > > p->action_mask0[RTE_PIPELINE_ACTION_PORT] = 0; > > + p->action_mask0[RTE_PIPELINE_ACTION_PORT_META] = 0; > > p->action_mask0[RTE_PIPELINE_ACTION_TABLE] = 0; > > > > /* Input port user actions */ > > @@ -1300,6 +1303,9 @@ rte_pipeline_run(struct rte_pipeline *p) > > p->action_mask0[RTE_PIPELINE_ACTION_PORT] |= > > p->action_mask1[ > > RTE_PIPELINE_ACTION_PORT]; > > + p->action_mask0[RTE_PIPELINE_ACTION_PORT_META] |= > > + p->action_mask1[ > > + RTE_PIPELINE_ACTION_PORT_META]; > > p->action_mask0[RTE_PIPELINE_ACTION_TABLE] |= > > p->action_mask1[ > > RTE_PIPELINE_ACTION_TABLE]; > > > > > > > > > > > > Thanks, Ildar > > Acked by: Cristian Dumitrescu No Cristian, you cannot ack this patch, even if it fixes the problem. The format is not OK: indent is wrong and it's not signed. Please Ildar, check http://dpdk.org/dev#send to know how to submit a patch. > Thank you, Ildar!