From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63D55A0A0C; Fri, 2 Jul 2021 14:30:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E970441353; Fri, 2 Jul 2021 14:30:41 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 992E140686 for ; Fri, 2 Jul 2021 14:30:40 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 2F52D5C00E1; Fri, 2 Jul 2021 08:30:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 02 Jul 2021 08:30:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= p8P+zti3NA2pZZuMsky/FjZIvGvXAn+Ep9Je/OHNX6c=; b=JQAlie2STRptBsnU n4K8i+Jvh7TJQejWIxS0Qm7URqf92kAO8qOCUM4QRd33XoTNGp4czuy7L9CyFg3B flWg7Z86c379xuB+r6vI2oDji88geemgN9KlOtbkL3ibkehiwdGABKFp215BYKw3 aDKRXbM0hBYfIuRLHNz6SwRh8IHDLbqWRFvgy3CJqN82SDbE4J+ue4AhW1w9kczM 0+wuBVZRSWA+Q5kpl3YymxcbLSaa3dEUC0Flsdt+AzT8nnZsGC2FxuGPmc7EiNcT n/zCc95r87RtUcZKFInI8+xNZ6UeFKah3GU01WWfALPO0yU2dLugllLOyjif/OLR OTDzlA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=p8P+zti3NA2pZZuMsky/FjZIvGvXAn+Ep9Je/OHNX 6c=; b=Yq86JROZRfAddJ5gUoByTtv2/thLDTQrluY0YXUh9rw+Y+PTxQ/7R+NSb WPwm9KOyjSFpNsc2Og1Nhye8LdS+q1lmvRj7ZJANZnwBfcTRneoE0m3AnGZ76n3C WQDa093cjiXLwJ9VIwrh2AFay65BegYqvxlnTRghssHary5isHE5FKH5CPvl4MGB WKyqQ4RTBhCV50wb8yhvgpmWWoP4Iv3/5g0V/NWczYex2qGlNgSCPeHpNkScyrpO nyF7jduN0SntcIZlJqXpnGsuaWMvifspGf9le8VPWJhahTKRbP6+inCMFqO1hhvv JFlTrdUDVyZkiZIEsSK5jRagdPPdg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeeikedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Jul 2021 08:30:38 -0400 (EDT) From: Thomas Monjalon To: David Marchand , Bruce Richardson , Andrew Rybchenko Cc: dev , Igor Romanov , Andy Moreton , Ivan Malov Date: Fri, 02 Jul 2021 14:30:35 +0200 Message-ID: <10487590.FxHezTWy5a@thomas> In-Reply-To: <0704be2b-674b-5e04-2c0e-ad8b0c528bf5@oktetlabs.ru> References: <20210527152510.1551026-1-andrew.rybchenko@oktetlabs.ru> <0704be2b-674b-5e04-2c0e-ad8b0c528bf5@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 19/20] net/sfc: support flow action COUNT in transfer rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/07/2021 10:43, Andrew Rybchenko: > On 7/1/21 4:05 PM, Andrew Rybchenko wrote: > > On 7/1/21 3:34 PM, David Marchand wrote: > >> On Thu, Jul 1, 2021 at 11:22 AM Andrew Rybchenko > >> wrote: > >>> The build works fine for me on FC34, but it has > >>> libatomic-11.1.1-3.fc34.x86_64 installed. > >> > >> I first produced the issue on my "old" FC32. > >> Afaics, for FC33 and later, gcc now depends on libatomic and the > >> problem won't be noticed. > >> FC32 and before are EOL, but I then reproduced the issue on RHEL 8 > >> (and Intel CI reported it on Centos 8 too). > > > > I see. Thanks for the clarification. > > > >>> > >>> I'd like to understand what we're trying to solve here. > >>> Are we trying to make meson to report the missing library > >>> correctly? > >>> > >>> If so, I think I can do simple check using cc.links() > >>> which will fail if the library is not found. I'll > >>> test that it works as expected if the library is not > >>> completely installed. > >>> > >> > >> I tried below diff, and it works for me. > >> "works" as in net/sfc gets disabled without libatomic installed: [...] > >> # for gcc compiles we need -latomic for 128-bit atomic ops > >> if cc.get_id() == 'gcc' > >> + code = '''#include > >> + void main() { printf("Atomilink me.\n"); } > >> + ''' > >> + if not cc.links(code, args: '-latomic', name: 'libatomic link check') > >> + build = false > >> + reason = 'missing dependency, "libatomic"' > >> + subdir_done() > >> + endif > >> ext_deps += cc.find_library('atomic') > >> endif > > > > Many thanks, LGTM. I'll pick it up and add comments why > > it is checked this way. > > > > I've send v4 with the problem fixed. However, I'm afraid > build test systems should be updated to have libatomic > correctly installed. Otherwise, they do not really check > net/sfc build. When testing on old systems, sfc won't be tested anymore after this patchset. On recent systems, sfc should be enabled I guess. I don't see how to manage better, sorry.