From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id E33AE376D for ; Wed, 15 Jul 2015 08:19:30 +0200 (CEST) Received: by wgkl9 with SMTP id l9so24701449wgk.1 for ; Tue, 14 Jul 2015 23:19:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=5MXNm49AkipR7lnwY5FIMnjXZMD5k+3xM4FeyXiPvNA=; b=Xq/9uPw3xgqUFw73TKMauvCfT9y3q27LvjwfvQFTcE9+Boh8xTYkuuCijTp6Cfv5Ag Y9JHtu7gnX350NNyh6G5CmWUXp0GeB+riaeUGIQv5KHzebIkHTwRCRNfbFpKs10N0cPq ILLSmZLOfJj3frhH8ldV2jrgAR4UQwYPXoxry2GeEdchS0qqvjCJlSppduJeMO1NdHk1 fnkzY+gYIP5k/xkgQpiPJOnoCsRtKFjU4YR2vQ8OG2KNsLPQK/QnYrpiubxcCUd810o2 6PWL83sF2qW+q+MZVpxDFVe7ve5lbqc167tOogCuUw8WmxV7+qZME6gsg+8TXcC/BYqn 0pjw== X-Gm-Message-State: ALoCoQktr0XhK1WWC1qadEFR7vvh4kpbRLpKN6IagK+6jVrZTujHc0crdu1dT8i0y2U8gheMoQ9J X-Received: by 10.180.83.137 with SMTP id q9mr42218298wiy.68.1436941170808; Tue, 14 Jul 2015 23:19:30 -0700 (PDT) Received: from xps13.localnet (153.16.90.92.rev.sfr.net. [92.90.16.153]) by smtp.gmail.com with ESMTPSA id ec19sm19596811wic.0.2015.07.14.23.19.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Jul 2015 23:19:29 -0700 (PDT) From: Thomas Monjalon To: "Wang, Liang-min" Date: Wed, 15 Jul 2015 07:53:05 +0200 Message-ID: <10500550.BxuzPEpZpz@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <3613205.a925kSz8Fg@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v16 0/6] User-space Ethtool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2015 06:19:31 -0000 2015-07-14 20:56, Wang, Liang-min: > Thomas, > The mac_addr_set is needed for ethtool net-op as described in > examples/ethtool-ethtool/lib/rte_ethtool.c (rte_ethtool_net_set/get_mac_addr). That's why it should be the first patch of this series. You probably misread "another patch" which means different patch in same series. > Could you use the v15 for the release? No, there are more comments. > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Tuesday, July 14, 2015 4:14 PM > > To: Wang, Liang-min > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v16 0/6] User-space Ethtool > > > > 2015-07-14 09:11, Liang-Min Larry Wang: > > > v16 changes: > > > - Re-do patch v15 and separate changes between v15 and v14 into patch > > files 005 and 006 > > > > No, you misunderstood the need. > > You must merge your fixes in appropriate patches. > > But you must separate the mac_addr_set feature in another patch as it is > > not related to ethtool dumps. > > > > You are winning the record of patch iterations :)