From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 449CA45AA7; Fri, 4 Oct 2024 05:54:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD7F5402DD; Fri, 4 Oct 2024 05:54:53 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2083.outbound.protection.outlook.com [40.107.212.83]) by mails.dpdk.org (Postfix) with ESMTP id 7D221402C9 for ; Fri, 4 Oct 2024 05:54:52 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tJdX0PiRIABVw20SziLtwN/Ru70Gmzldmefpx6VkyV4+w+7cewBcznE0B0sutn7S35bK0p6RETxs1sY9tbF1HPXZ+RI/Br4P5GUQdyRSsSiZ2vD34wdisjGyODEzze2dsRnPI/rwUyk0QBGis1QxJWizvRHDCC0crzhh/Nol5SyI5ymE6ICR/LCn1RToV9iV9uBMLREmEOB256pocKNPKUSSOyXOzMAxhBT3ADtmB+CQnmQQvYlornPy9uET94EfGyWVcqzp6mjNuKTVhigroXldk/XH5Ci/RNl7mw1Prw22p40BiHDxl3kS0870RXvA1MpDq6nk61Th5A2FKKf3lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=peE0GR3bJ5twWYecWBfM/gHq07bXjpgGkOGsjl95XBU=; b=N/9pdJL1+vxMl+2o+AxLu9CjYsYVa+nhFRNTxc3wvesd0V3bbe5lkKlrbr0bKETruqGCFRwU/1dledHfGlvl8Kd1D8nxrlGRZ5HutbVB7C8r6L/TEkClIHBauHXNJbfGtn5oLUwy6VZRtrYRgr+FBTZIAzX0H9vBb9KM5TivGZuKdkGUFLTZuFYRe/jCay2XXkyNNbaX5QURjk2JpMumKpHW+dtUedyy20EZkmmmpKIGGXIRpCvb5VAN6A6sBLnixyvYN42a+41DbLAOL0mn44jAKB4gmIIY8OynQP1i0PtWlL42CYNXlODPC2sStM8egGHIsJCkjx1pmJKbiLSPYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=peE0GR3bJ5twWYecWBfM/gHq07bXjpgGkOGsjl95XBU=; b=o/2d8VTug/y4yoneKr2vG7v+2p5XMPa7celC6HsqdjaJtqAI9uQLd7liuSc44Kt6QuOJ8M2cFYuMTKZ9RB2R1VY12Jx9wkFc4wUpjJA6wuTLjM6YAfRSetmTSUJlQYTvuG9afeq+smQVCuV73STFJz7zAJhjPA9ac4mIgpc+fK4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by BY1PR12MB8445.namprd12.prod.outlook.com (2603:10b6:a03:523::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.25; Fri, 4 Oct 2024 03:54:49 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8026.017; Fri, 4 Oct 2024 03:54:49 +0000 Message-ID: <10591cfb-d78e-4d50-9bb5-f6d1246662b3@amd.com> Date: Fri, 4 Oct 2024 04:54:38 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs To: Akhil Goyal , dev@dpdk.org, Dodji Seketeli Cc: thomas@monjalon.net, david.marchand@redhat.com, hemant.agrawal@nxp.com, anoobj@marvell.com, pablo.de.lara.guarch@intel.com, fiona.trahe@intel.com, declan.doherty@intel.com, matan@nvidia.com, g.singh@nxp.com, fanzhang.oss@gmail.com, jianjay.zhou@huawei.com, asomalap@amd.com, ruifeng.wang@arm.com, konstantin.v.ananyev@yandex.ru, radu.nicolau@intel.com, ajit.khaparde@broadcom.com, rnagadheeraj@marvell.com, mdr@ashroe.eu References: <20240905101438.3888274-1-gakhil@marvell.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240905101438.3888274-1-gakhil@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0499.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::6) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|BY1PR12MB8445:EE_ X-MS-Office365-Filtering-Correlation-Id: 0549e0ab-dccc-4257-bbe7-08dce4284b0f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|7416014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QnowejhlSmlIYTN5V3Y3d2x1MWZxa0J4Z3RPM2RJQ3FxZGhKMkJvV2tHVUl1?= =?utf-8?B?M0VCeGgwdnhZRFplY2VHZ1gwRytPRzRGd0NOZ1ZrcVlqTUlGbTdZSVl0RDVr?= =?utf-8?B?QlR1bGVIdW9HeTFQbHZsZHdWdjNQcHBLUms1enRDeXN4b3ZqWmdGQmp6b0tW?= =?utf-8?B?a0cyM3FDZFlKSWtpMWVoNnRjVnh6U0QzQ05NRWwzd3pOQjc2UU55cmNpdnZL?= =?utf-8?B?UCtFaU82cWZpL3BuNStCOVdTZEEwMEtHQUk4dDV3d2xoc0JjSkE3K05UcVR6?= =?utf-8?B?cUY0SjZPdVFPdDc4eXl1ek9ZcFVMNUlweml4UEpvelh2czVyaVJWV3BDRlVq?= =?utf-8?B?MnQzNUpxM1dDT1M5V1FSdjB6eHkwR3BJRmxBUU5xRy80blJZZWZVb3ZYcnpU?= =?utf-8?B?b25XMXBXdzVzT0o0ckl6cE56ZkF0ajZTNFIrbnVHTG1YNTZRMGVqRzluQ2FZ?= =?utf-8?B?bDA5ZGRxQS80bzd1OTBpdVFvYkV6bG1xVUQzVDdUc2RXcy9GS2cwMXdueFVZ?= =?utf-8?B?NmF3Qm5PQjQ4cEttdHNubTVtRklLWXc3VFJaQkg5cVcxK2NUNXo3cS9TL1Fh?= =?utf-8?B?T0JzcUtZRU9mK1dyRi9vTUNQRk40N2J1aVNyZVJBWlRZVVNJZ1haaC9EaHNa?= =?utf-8?B?S0J4eXozSlpuSFlBdjlLQTdwZnFLU1pNK2hDdWFsSmZPcmFLaTF3dllaaTZR?= =?utf-8?B?SjQwd21LMmxCVHVNdVl3dHNZTHhERUFONDBSQTlhbHRyd092aDVLbXIvdTh6?= =?utf-8?B?SGdUeVpaYnU1MnRQMklZSlBtRVU4ckI0WVpNbm53SVBKMVdsWDM1YjF0TkpO?= =?utf-8?B?dW4rSUluOFVSQnZ4aDlycVVyZHkvaCtya0dRNEFmWDI0eWszY3Vmd1ZFdGIz?= =?utf-8?B?emxvR3Q3cnpwVW1vRmN5QU8zOUlEMHRieWNnL3RLWTJ5cmNyeGRMRlhaR3U2?= =?utf-8?B?NEtHeEgxMjMvM1dVMEtVb1RTdTRwSXNLN2wvSHFjL3ozeTNPWnVTYUJId2cr?= =?utf-8?B?SEovb2JGWmtNdCszRG5od0NidjB4OVlNL1Myd1B2dGxGMlkxRDRYNWd3VDBW?= =?utf-8?B?NWpQU2lhSGI4c3FqdVIrcURnME00SW1Sbm9GRGRoWml4UnBPYk9PbG5zT2o3?= =?utf-8?B?cGZVNE56cXk1dVlXMXc3c0lXUFcyL3RCQU9HOVdVaFByV2pFOVY1Q3Q2ZGhH?= =?utf-8?B?TFl6MHJMQ1hxaXl0UDJNOGtqNlYzbzFoRUZ2Z2hxMVplbjRUNXlQQTdDaEx0?= =?utf-8?B?bTNZRjJKNkpmV2hiRnN2ZzRVbFlNYWR4MytlQ1R6VTJqL2hFeEFER1pBWDQ1?= =?utf-8?B?bmQ5NVBFUWlZY1NYN2ZrSUpEbVR2Zzl0VXN2emRYT3Y4ODZqUk9oYWtDK0JN?= =?utf-8?B?SDRMVDRFWU5iTWNsT242ZUR1TFdhc3lodEpUQ3RaUlBUdGJCOTA5TlNCYnNy?= =?utf-8?B?ek5ENExQa0tCQlp4WkNtN0RoajVzL2s4alNmUDlQZXhYVEhKZlJ6QUhxblNT?= =?utf-8?B?eklZbWZLeHhmZUVxZC9MbTExeFRKTEVnSUxrN2hRRk50bUc2UWpGOVJpYkg2?= =?utf-8?B?VDBzQ2ZlaE12WVluUmtDM3pmVm9tZ0hSUmhIcWdBanNROHVWUFdaVlBQbXds?= =?utf-8?B?MFNrcG5Ud3A3TEozemEvYjhxemZQNW1jcThuVkIreHk0OWlGT1M2bzVSTGJ2?= =?utf-8?B?NXk2eUJpYXhIQmJVQitMeHZwd1F1OVB0YUNQM0szVUNLbHM4SDh5dlV3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(7416014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TEhNR1RpeTlVZnhtOUtBY2owTkVoUXR4dFA0VWlzRnF1eG5aL2Z1VW5GYk4x?= =?utf-8?B?aHEwZnJHSmsvbllBeWI1ZEJXaWFxRTNZdzI0V3N5WEw0R2hGTXMrZi9zSGdo?= =?utf-8?B?QTBNUUJJQmZWTzk3YkVha3h5M0QzRnQyNFBaT0t3TDVwNlB6czhzM2VvQ3Zm?= =?utf-8?B?aWZhdnYwV1ZvVHR3bTN0TFg3M2Y3WkhlVmVVemNMQm42bWFUSUE4UXJVL0I0?= =?utf-8?B?aFhkK0w5QUxIcW9KU0tITndSSWRTRVFsLzl0UGswR3BVOEt4NXEwVEJid3JS?= =?utf-8?B?RldZM1pKaHp2aHp2aDkwRHd1WE92YXJ0eHF3cEZWUU1teUthc0t4K0lNZ1oz?= =?utf-8?B?OG1xRE9yRFhCcWdMNVJvdVBFblR2TGgrNGJLS1hpUVdUM1Q4dDJldHppTEll?= =?utf-8?B?cFRJamd5TzRTN2M0bVZtY2VORDBLa21pV1NKMVpxWnVxMm1QMzY3N29DZnB6?= =?utf-8?B?S3BnbUNEelBXRkNVYU54Tm4wV0Z5Smt2QXRBcWNHWmd0QW1wNVEyV1VmOHpu?= =?utf-8?B?OW5Na2dxcWRRTUNacnAxUFJMcGQwSGpBRGZscytKL3JJdThTRzNsbVJqRUxm?= =?utf-8?B?Q0hYNmRJMm10K0xXT3RCUjNEaDJmaEdrb3A2NTdzVEVtZHhNd3RKY1NjV1Zs?= =?utf-8?B?MHJLRGFFdTBBZFJoZDJoVjVPQVhVWkZ4VlhKNjdOL0kyUE9RbFZPU2VlUnFh?= =?utf-8?B?YnpsUytGSTRvMkxmUFNYOUxxT1BNZG1YZzZoN2ZRZ2daelNwN2lOR2hKRlZV?= =?utf-8?B?ZklVdWdvR1lkdzd5VlkvRHNrYTg4WnR4VVZnQmY4NWZJYzZjT2pwYTk4em1S?= =?utf-8?B?Nld6WlNxOTFnQUFwM3FLTExUd3pVbjNCcURKZzQ4Z1hRRHRNN3dpN1ZvU1NU?= =?utf-8?B?VmpOU1ZQYWE1TGZCa2ZMbWVubWFhaUthbW5oMWpWRWRZR01LTW81dk5CMWU1?= =?utf-8?B?YU5GN0R3WVg2dHNKaEdZNnQvV3AxQTJTQXZKZzZFREhuWC9NdGczMjdsQ3lk?= =?utf-8?B?Z0dDYkh2c0NOYXlvWXhWVDJKYjZtNWtycWt6TjdLTjJTTHhXWUtPYTFYTlR0?= =?utf-8?B?dVBaeVhOaWwzTVZhVjRYenJlR3hBWHNoZFhVYStZWVVKZXNRWW5IZTVhK1NL?= =?utf-8?B?QTBkY21acTRBY1owWXdMbmR3TlFvOHovWkRSQ1BDY0wrdGZZT2E3SmNDYWM4?= =?utf-8?B?R0lpU05SVWd1ZkIvR3U5bG9UV0FvYXBMOGMreGZBVWpkTTVxWjJZNjdCMlRa?= =?utf-8?B?SmplL1hxU3J3c2prSmJ0NDd4ZTZ5dXJ0TGdBWGlLVmhLNmpIV2VqS1hqb3N1?= =?utf-8?B?eDdVRzVzM0lRZS9CdDRmWDZ2QVRhTVlmM05tRjQxYjc5aHRLMnZMYXdYN3d1?= =?utf-8?B?NDg0YndqbTd5WU1lM2FzZ0szRExyT1M0U28wUHM1QnNndFNQRTlOWUFCdzZG?= =?utf-8?B?L1BnRXc5a0VKSnVvWmNXQWZ2VUozZzZnUVN5OTVDOGhPWUszSWRWUURtU2RP?= =?utf-8?B?VVVUckE1NXQyRjlCdmlaMEdJUE1paVNRQ0pyTkpJR0FPVGh3b3lGc29HV0ZY?= =?utf-8?B?eUtXc0xicXM0OGZvOStpRGwvSXRJRTBjbjNCckgrVmtWaDFPTTBkNXcyek1s?= =?utf-8?B?S0RYMHl1SzRtOVZ2ZDB5Z3R1dlltVzFBTEVrN1FwWG9HMnViZGtjUzhXUGlG?= =?utf-8?B?b0EzbFI5YkkwbUV2WkRvaloxYmZ1NG01WFFLMExjYTRpZU43SGN1dzU1eUQ4?= =?utf-8?B?NWdDRS9BOVFuUnBENDdhWk5OMUdGWnVCMUlhNVFwNGVTUTh6OU9OdmZxckhO?= =?utf-8?B?YTlSc2pFbGEvcGo5eGc5bTRqdUVOSW9hK3c5VEFzUjYwVmNqRzFUeWZDOUNx?= =?utf-8?B?TkRSeFU3cFJuOVZTYVJXdStNcEM2ektmZlB1alU3bEFWY0tWQTZyRG0rWGtn?= =?utf-8?B?WnJtcGtZbVdFWDBOUGFSOTU2MnFzNEhJRWUzbzZabVZsWnhZTTlDNDk0RjJk?= =?utf-8?B?V2dFVHAxaXgxKzB0YmFoT2R1V1BvSUNCR2JyZWVLUlJnZVk4aGNZWGRwNmtj?= =?utf-8?B?MmFDMFFTeVYyZlhlRE1nZVNxYVpxRUhsUENyaW1VenNZRU1VVUNvMmJJTlRY?= =?utf-8?Q?02HqahNDdgzXJYIMpFRL4koJl?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0549e0ab-dccc-4257-bbe7-08dce4284b0f X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2024 03:54:49.1553 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PdVkqJFwJt9LPUonpCXmdVPqemJKF+wO6qTMWjONgKEEPCI7bF6wdoLkkIh35OF2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR12MB8445 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/5/2024 11:14 AM, Akhil Goyal wrote: > Replace *_LIST_END enumerators from asymmetric crypto > lib to avoid ABI breakage for every new addition in > enums with inline APIs. > > Signed-off-by: Akhil Goyal > --- > This patch was discussed in ML long time back. > https://patches.dpdk.org/project/dpdk/patch/20211008204516.3497060-1-gakhil@marvell.com/ > Now added inline APIs for getting the list end which need to be updated > for each new entry to the enum. This shall help in avoiding ABI break > for adding new algo. > Hi Akhil, *I think* this hides the problem instead of fixing it, and this may be partially because of the tooling (libabigail) limitation. This patch prevents the libabigail warning, true, but it doesn't improve anything from the application's perspective. Before or after this patch, application knows a fixed value as END value. Not all changes in the END (MAX) enum values cause ABI break, but tool warns on all, that is why I think this may be tooling limitation [1]. (Just to stress, I am NOT talking about regular enum values change, I am talking about only END (MAX) value changes caused by appending new enum items.) As far as I can see (please Dodji, David correct me if I am wrong) ABI break only happens if application and library exchange enum values in the API (directly or within a struct). Exchanging enum values via API cause ABI issues because: 1. enum size is not fixed, it uses min storage size that can hold all values, adding new enums may cause its size change and of course this breaks ABI. 2. Library can send enum values that application doesn't know, this may cause application behave undefined. 3. Application sending MAX value (or more) to API expects error, but that may be a valid value in the new library and applications gets unexpected result. Let's assume above 1. happens, with this patch warning is prevented, but ABI break still can occur. One option can be not exchanging enums in APIs at all, this way changes in the END (MAX) enum values are harmless. But I can see cryptodev does this a lot. When enum is exchanged in APIs, and if we want to be strict about the ABI, safest option can be not appending to enums at all, and keeping END (MAX) items can be a way to enable warnings for this. More relaxed option is protect against only 1. since that is the real ABI issue, 2 & 3 are more defensive programming, so as long as enum size is not changed we may ignore the END (MAX) value change warnings. [1] It would be better if tool gives END (MAX) enum value warnings only if it is exchanged in an API, but not sure if this can be possible to detect. > app/test/test_cryptodev_asym.c | 2 +- > lib/cryptodev/rte_crypto_asym.h | 18 ++++++++++++++---- > 2 files changed, 15 insertions(+), 5 deletions(-) > > diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c > index f0b5d38543..f1ece475b8 100644 > --- a/app/test/test_cryptodev_asym.c > +++ b/app/test/test_cryptodev_asym.c > @@ -581,7 +581,7 @@ static inline void print_asym_capa( > rte_cryptodev_asym_get_xform_string(capa->xform_type)); > printf("operation supported -"); > > - for (i = 0; i < RTE_CRYPTO_ASYM_OP_LIST_END; i++) { > + for (i = 0; i < rte_crypto_asym_op_list_end(); i++) { > /* check supported operations */ > if (rte_cryptodev_asym_xform_capability_check_optype(capa, i)) { > if (capa->xform_type == RTE_CRYPTO_ASYM_XFORM_DH) > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h > index 39d3da3952..290b300f84 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -72,6 +72,7 @@ enum rte_crypto_curve_id { > * Asymmetric crypto transformation types. > * Each xform type maps to one asymmetric algorithm > * performing specific operation > + * Note: Update rte_crypto_asym_xform_type_list_end() for every new type added. > */ > enum rte_crypto_asym_xform_type { > RTE_CRYPTO_ASYM_XFORM_UNSPECIFIED = 0, > @@ -119,12 +120,17 @@ enum rte_crypto_asym_xform_type { > * Performs Encrypt, Decrypt, Sign and Verify. > * Refer to rte_crypto_asym_op_type. > */ > - RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END > - /**< End of list */ > }; > > +static inline int > +rte_crypto_asym_xform_type_list_end(void) > +{ > + return RTE_CRYPTO_ASYM_XFORM_SM2 + 1; > +} > + > /** > * Asymmetric crypto operation type variants > + * Note: Update rte_crypto_asym_op_list_end for every new type added. > */ > enum rte_crypto_asym_op_type { > RTE_CRYPTO_ASYM_OP_ENCRYPT, > @@ -135,9 +141,14 @@ enum rte_crypto_asym_op_type { > /**< Signature Generation operation */ > RTE_CRYPTO_ASYM_OP_VERIFY, > /**< Signature Verification operation */ > - RTE_CRYPTO_ASYM_OP_LIST_END > }; > > +static inline int > +rte_crypto_asym_op_list_end(void) > +{ > + return RTE_CRYPTO_ASYM_OP_VERIFY + 1; > +} > + > /** > * Asymmetric crypto key exchange operation type > */ > @@ -168,7 +179,6 @@ enum rte_crypto_rsa_padding_type { > /**< RSA PKCS#1 OAEP padding scheme */ > RTE_CRYPTO_RSA_PADDING_PSS, > /**< RSA PKCS#1 PSS padding scheme */ > - RTE_CRYPTO_RSA_PADDING_TYPE_LIST_END > }; > > /**