DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Wang, Yipeng1" <yipeng1.wang@intel.com>,
	Dharmik Thakkar <dharmik.thakkar@arm.com>
Cc: dev@dpdk.org, "Gobriel, Sameh" <sameh.gobriel@intel.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	"honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>
Subject: Re: [dpdk-dev] [PATCH] lib/hash: remove unnecessary locks in lock-free
Date: Mon, 25 Nov 2019 22:54:54 +0100	[thread overview]
Message-ID: <10640783.jF6kOFs2fc@xps> (raw)
In-Reply-To: <D2C4A16CA39F7F4E8E384D204491D7A673F3F02E@ORSMSX104.amr.corp.intel.com>

25/11/2019 19:49, Wang, Yipeng1:
> >-----Original Message-----
> >From: Dharmik Thakkar [mailto:dharmik.thakkar@arm.com]
> >Sent: Thursday, November 21, 2019 10:18 AM
> >To: Wang, Yipeng1 <yipeng1.wang@intel.com>; Gobriel, Sameh <sameh.gobriel@intel.com>; Richardson, Bruce
> ><bruce.richardson@intel.com>
> >Cc: dev@dpdk.org; honnappa.nagarahalli@arm.com; Dharmik Thakkar <dharmik.thakkar@arm.com>
> >Subject: [PATCH] lib/hash: remove unnecessary locks in lock-free
> >
> >Remove __hash_rw_reader_unlock() calls from lock free hash lookup
> >
> >Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> >Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> >Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> >---
> Acked-by: Yipeng Wang <yipeng1.wang@intel.com>
> 
> Thanks for the patch!

Excuse me, there is no motivation (the why) in this patch.
Is it critical? which gain?



  reply	other threads:[~2019-11-25 21:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-21 18:17 Dharmik Thakkar
2019-11-25 18:49 ` Wang, Yipeng1
2019-11-25 21:54   ` Thomas Monjalon [this message]
2019-11-25 22:02     ` Wang, Yipeng1
2019-11-25 22:44       ` Thomas Monjalon
2019-11-25 22:55         ` Dharmik Thakkar
2019-11-25 23:14           ` Thomas Monjalon
2020-01-17 16:42             ` Dharmik Thakkar
2020-01-19 23:37   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10640783.jF6kOFs2fc@xps \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=dharmik.thakkar@arm.com \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=sameh.gobriel@intel.com \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).