From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8D88A0524; Wed, 5 May 2021 23:39:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 505ED410E0; Wed, 5 May 2021 23:39:27 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id D8DA640040; Wed, 5 May 2021 23:39:25 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8AADA5C019D; Wed, 5 May 2021 17:39:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 05 May 2021 17:39:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= ZzRhjkvZK4oVOFKc6OLRhJ2MP09KgWP2eqpX+sPwzyE=; b=piddCu9JIBd7IRhh pR7FtMhha9dmT+IMhxMrNe6Nhv6uTgk0yipOEFuLTq8slKvr4b7FImPYgcYDC/ds dlIf+AyHiP7HPs7qsf8+sXKZPTg2+OqSq9X2KAAu1ZmR09ZfdYibCPBa2AeusaFp 4mw4idgKbntsqdCgNLchd+dKR6ttbE6pQx6TK1xX4uJlznQi3FMHkl6QOrrixRB0 iXLgfdyLRbYWkk2duAL8JLWXqKRfLhgFwVlRAcKazrmt0LNzB1HUkEZxR8d64AX4 0b0MWtECoQt+L1oq8RkqLrlQKstZnecSVAjH+7NkNIiOMpZhma0Wq5Qk21FMzew0 iR+A9w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ZzRhjkvZK4oVOFKc6OLRhJ2MP09KgWP2eqpX+sPwz yE=; b=EOiCiERzX23s4/OvA+BoxhMdoiE74xoVojKMr2XFb8TAdZ5xYaDsE0Faz ff0Dol6uD9qj7Z2TBna+NDNJNJ2vNFtbk5Bv5WVNEu+t51Re2fYuZz9+YZKH9bka wBqDSgt+tSrg8jkgg2e+W0imXqyvJ6hH0IcYp1+R4GfCO7VjRjB6P5zsUeDoVV+z AANoU90Vd+A1+JaQko0pYUGS94LPZRAzNhtdWcvw3LpgARfHxzcFvqiuxISBn4JJ LY7OuAF+dYKMOn75QWopVGu4NAbHNsCt57Rs+hEq2BaU5U54rETicpD3FNrhRvxQ Rq6eAzwfr4dYpOVsdxNMLluaN5ejg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdefkedgudeitdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 May 2021 17:39:24 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: stable@dpdk.org, dev@dpdk.org, Bruce Richardson , John McNamara , Tyler Retzlaff Date: Wed, 05 May 2021 23:39:23 +0200 Message-ID: <10660804.QYKOPib57F@thomas> In-Reply-To: <20210505160042.GB13051@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20210502025656.29910-1-dmitry.kozliuk@gmail.com> <20210504094822.7072ef01@sovereign> <20210505160042.GB13051@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/rxtx_callbacks: fix port ID format specifier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/05/2021 18:00, Tyler Retzlaff: > On Tue, May 04, 2021 at 09:48:22AM +0300, Dmitry Kozlyuk wrote: > > 2021-05-03 17:11 (UTC-0700), Tyler Retzlaff: > > > On Sun, May 02, 2021 at 05:56:56AM +0300, Dmitry Kozlyuk wrote: > > > > Use "%u" and a cast as in other places when port ID is formatted. > > > > This fixes -Wformat warning with clang 10.0.0 on Windows. > > > > > > > > Fixes: f8244c6399d9 ("ethdev: increase port id range") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Dmitry Kozlyuk [...] > > > > - rte_exit(EXIT_FAILURE, "Cannot init port %"PRIu8"\n", > > > > - portid); > > > > > > how come not just `% " PRIu16 "\n"' ? > > > > > > what was the -Wformat clang on windows complaint? > > > > PRIx16 would work, but I noticed that in other places where port ID is > > printed, the pattern above is used. IMO uniform approach is better. > > ah, consistency. yes i'll have some of that. maybe one day in the future > we can change them all in one shot, but not today. > > Acked-By: Tyler Retzlaff I think PRIu16 is more appropriate. Consistency doesn't matter if an approach is better.