From: Thomas Monjalon <thomas@monjalon.net>
To: Jeff Daly <jeffd@silicom-usa.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "Yang, Qiming" <qiming.yang@intel.com>,
"Wu, Wenjun1" <wenjun1.wu@intel.com>,
"Zhao1, Wei" <wei.zhao1@intel.com>,
Xiao Zhang <xiao.zhang@intel.com>,
Xiaolong Ye <xiaolong.ye@intel.com>,
Lunyuan Cui <lunyuanx.cui@intel.com>,
dev@dpdk.org, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [PATCH] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices
Date: Wed, 11 May 2022 16:50:47 +0200 [thread overview]
Message-ID: <10661272.5MRjnR8RnV@thomas> (raw)
In-Reply-To: <36a68dda846440738e43d83a105b358c@intel.com>
11/05/2022 13:43, Zhang, Qi Z:
> From: Jeff Daly <jeffd@silicom-usa.com>
> >
> > 1ca05831b9b added a check that SDP3 (used as a TX_DISABLE output to the SFP
> > cage on these cards) is not asserted to avoid incorrectly reporting link up when
> > the SFP's laser is turned off.
> >
> > ff8162cb957 limited this workaround to fiber ports
> >
> > This patch:
> > * Adds devarg 'fiber_sdp3_no_tx_disable' not all fiber ixgbe devs use
> > SDP3 as TX_DISABLE
> >
> > Fixes: 1ca05831b9b ("net/ixgbe: fix link status")
> > Fixes: ff8162cb957 ("net/ixgbe: fix link status")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jeff Daly <jeffd@silicom-usa.com>
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Applied to dpdk-next-net-intel.
There is a lack of context in this description.
I don't know what SDP3 and TX_DISABLE refers to.
Please make more complete sentences, thanks.
next prev parent reply other threads:[~2022-05-11 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 18:57 Jeff Daly
2022-05-11 11:43 ` Zhang, Qi Z
2022-05-11 14:50 ` Thomas Monjalon [this message]
2022-05-12 17:01 ` Jeff Daly
2022-05-12 19:15 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10661272.5MRjnR8RnV@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jeffd@silicom-usa.com \
--cc=lunyuanx.cui@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
--cc=wenjun1.wu@intel.com \
--cc=xiao.zhang@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).