From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B59C4A04B3; Mon, 10 Feb 2020 10:52:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B79391BDFD; Mon, 10 Feb 2020 10:52:58 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id F0F6454AE for ; Mon, 10 Feb 2020 10:52:57 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 57DBB21AFB; Mon, 10 Feb 2020 04:52:56 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 10 Feb 2020 04:52:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Wuxab74PQBYpcYquMpeZf7k+cmo9aoMzOyEugy7P9vU=; b=sBg/2evAybxZ zrPUID0r3BRKJhqYmBxynesKtovqucXk4m8OTwNWdXhU7LWhAgnGCeCcj2nodP5n 8Bq64R9V3EJ3xsusPC5HmIhskKAecRv/uJe+Z4L1/rXKmGC1cqNhZTd1ac9LGK0A 6pU8kFRBlMVgfQOzmmCp5Xl1paKxlR8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Wuxab74PQBYpcYquMpeZf7k+cmo9aoMzOyEugy7P9 vU=; b=G/VmAR6uY9Gy8lzwTPV35q139TPH3zmscluzUeLZpiAMPoLBXltXT3XRP oPzuPhAxkvRwaD4/nvUVsoo+aamnH4XxinDs5r4l5U08MMYS8mB72D57KkaAAmUE 7fwi5THQgRDHSYqE6r71a+n7OCDx8JEfwigMwBabM4JPKRdIMA19fTKybCscLc4X jmfIL+MqEOHI2eReU+Km4rPCr24vgpK26NPyaLgfel+FDocm3qgf31GK6Pr+jiz0 J3BHqamGqi+NvWIsNB10KnurFGKhP4uky21KKHW13t2ExUGO2H8l3DMhxiYHk6WF 1hAn1k+ymeBfPG62n/7AmY1PNWXgQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedriedugddtkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 906F23060717; Mon, 10 Feb 2020 04:52:55 -0500 (EST) From: Thomas Monjalon To: Matan Azrad Cc: Shahaf Shuler , Slava Ovsiienko , "dev@dpdk.org" Date: Mon, 10 Feb 2020 10:52:54 +0100 Message-ID: <10685611.F0gNSz5aLb@xps> In-Reply-To: <7829300.5OynTdThKG@xps> References: <20200209211725.197237-1-thomas@monjalon.net> <7829300.5OynTdThKG@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/mlx: replace hardcoded value with macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/02/2020 09:52, Thomas Monjalon: > 10/02/2020 07:32, Matan Azrad: > > From: Thomas Monjalon > > > > > Replace checking against 65535 limit, > > > with a simpler form using RTE_MIN and UINT16_MAX macros. > > > > > > Signed-off-by: Thomas Monjalon > > > --- > > > > No more misusing of *_MAX \ RTE_MIN\RTE_MAX in the mlx PMDs? > > Sorry I don't understand your question. If you are asking if there are more hardcoded constants, the answer is yes but they are masks. I think the masks can remain hardcoded.