From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD8E4A04B5; Tue, 27 Oct 2020 17:22:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1803D6A15; Tue, 27 Oct 2020 17:22:54 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id F2F7C5AB9 for ; Tue, 27 Oct 2020 17:22:51 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 85F4A5C00FF; Tue, 27 Oct 2020 12:22:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 27 Oct 2020 12:22:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= kIBNHKIU4YDLYhXPEKLSMKPB5RStw86td0cLvawFHDs=; b=GcWjwp5v0UzqWYHI v9+XZk8AbHB0nhiMqmTKFsAt9rjvd5p2doy+NqPxdIcUAcgqqhqYjKgWPstaF8ye 2gvTtThaoyghTMFODv5GaICptloowxL01A5toKfXXuZo9kZYvTQOgBMWkyWnJ4az TcW3P1y7ojVdcgD70/pG+U4fTi0I3XwiSOV0X1kD+QWK5deESCei0pbcLYRAXqy/ 79CNyenRIxFIwRHo4EjQUP0GdYTOcoiSod80UQwGN3x2ZH+TLP64iR2vud31ZoXN agH7WE2yS858wLAO1MqKrbXpgG3xMaJFYg1sv3WklDQHb+cgmH0yAWMMaUfvEpzO iviqcA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=kIBNHKIU4YDLYhXPEKLSMKPB5RStw86td0cLvawFH Ds=; b=Ia+Jjl5Mn7/0zOgB0vBZzK+XioTehp5EfPDhH9I4r3JXBjusRD4iUGyxJ NivjvTPrAaKKe23Vs/GznMXco0OQnWA3m9zv/aFy+H78eGFyksnIcxKVfydx+rVW 3OTA48bqsjmV58ycLVbUUUMRc3NXSGL9jS/RC8mecjE/waFrwm6GcoYVX1axHRsX /kQjBHk+I6qsaB+aG0d7P453xly/IttrpngU1O/N0gxR2fdT2Hx1YvA5GciJp4PA 137wiKb5oUdQeGZlXsAHz0k9AEKGoRIrhavtFXVKh/LJXFJ6dxGInghI7gBrygUK O1CwAFrJKeChY5fPVCBbff6xpQhRA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrkeelgdekjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeehteff vdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvd dtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 987393280060; Tue, 27 Oct 2020 12:22:48 -0400 (EDT) From: Thomas Monjalon To: Olivier Matz Cc: dev@dpdk.org, ferruh.yigit@intel.com, david.marchand@redhat.com, bruce.richardson@intel.com, andrew.rybchenko@oktetlabs.ru, akhil.goyal@nxp.com, Ajit Khaparde , Somnath Kotur Date: Tue, 27 Oct 2020 17:22:47 +0100 Message-ID: <10693239.WuTJGR7auk@thomas> In-Reply-To: <20201027103124.GQ1898@platinum> References: <20201026052105.1561859-1-thomas@monjalon.net> <20201026222013.2147904-9-thomas@monjalon.net> <20201027103124.GQ1898@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 08/15] net/bnxt: switch CFA code to dynamic mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/10/2020 11:31, Olivier Matz: > On Mon, Oct 26, 2020 at 11:20:06PM +0100, Thomas Monjalon wrote: > > The CFA code from mark was stored in the deprecated mbuf field udata64. > > It is moved to a dynamic field in order to allow removal of udata64. > > > > Note: the new field has 32 bits, smaller than udata64. > > > > Signed-off-by: Thomas Monjalon > > How is it used by an application? > It seems that the cfa code is not always set. Is there a flag to > know when the field is valid? I don't know, and it is PMD-specific, but this behaviour is equivalent with what was before. > Also, for ice and iavf PMDs, we were discussing what is the better > way to export the offset. > > Note that there is an open discussion about how to export dynamic > fields offset for PMDs: > http://inbox.dpdk.org/dev/20201025071352.221953-1-haiyue.wang@intel.com/T/#mab79dd5cbb7d199a33515b7456dfe1831cf473bc In general I think it is better not exporting the offset, but keep a local copy of it.