From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 716E0A00C5; Sun, 5 Jul 2020 16:52:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4BE471DA55; Sun, 5 Jul 2020 16:52:37 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 615BF1DA54 for ; Sun, 5 Jul 2020 16:52:35 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 113A35C007D; Sun, 5 Jul 2020 10:52:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sun, 05 Jul 2020 10:52:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= MI9m76WZCuP0VO1zoTtAnlfezkhmnS7eyhaP9/IfVns=; b=qaZNso83YCQmF/AQ Dufd6++T1FNsf02P9IWtVntMOR7ik9n7xCMMjvbTVo9LN8YQTRiYvPP9+UKXauGH BoKZ1uhBVZGhFMzhXS1CVZBFlQDIRm3bav35dcowexloM1SIspxAXpXelUIvCPy8 7d4R21rWOyEvMgUTK9ZKpKNbdK9uXJh0GK4mW66UbFc6ygnNCHZ27EbyL9tUMLJj HREZSNH7W4Q9KOqJO5knrpQyelXHfF5eNktY5+6YJE+sVz3qLUO1UMrRMF0v2e4E LfAPdb5POG3WRymK0qeIPKxqhN5d+XHOtUFiPupNN+JuZfGRFhR4EWFRpJP9zxlk 8MkYCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=MI9m76WZCuP0VO1zoTtAnlfezkhmnS7eyhaP9/IfV ns=; b=eflBt2fat/oXICiLXmgY7erglK539VrMw6we89EhgCBskrmj3HowhkqWf WXI1+KAHhX+1snkHcgTmi8+vTv2q3k5vIVMYb8YvM4AFGTrmtaxdPqn/lfYPdXJj 3/uIKaUklZyG68FQLYRAzI6aPTLCGT63sXQ/CkCiViVjXESNeYgh0YofzlAdR+rL VXHwpzk8ev7ZoGDWppKbOqbIKvFQFQ2epnxFsLhiYbyplQiTXSc8KsApfzs5pU8A AXPW/+jhEk/TX7VM7MaI+r9QiiNS1bCc94lP7S/zrVUqQX755VLb9HV1sIiTlCgL HqxOSPdMxIDv81FS8c8BGZTId9opA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedruddugdekfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeelieeivdekheeigefhkeeutdehhfdtjeevfedtieduvefhtdeihedu hfegvdelffenucffohhmrghinhepghhnuhdrohhrghenucfkphepjeejrddufeegrddvtd efrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1FE49306A468; Sun, 5 Jul 2020 10:52:33 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, Harry van Haaren Date: Sun, 05 Jul 2020 16:52:32 +0200 Message-ID: <10700032.x8Otjhmkp9@thomas> In-Reply-To: <20200704114801.1110659-1-bruce.richardson@intel.com> References: <20200617104012.470617-1-bruce.richardson@intel.com> <20200704114801.1110659-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] build: check functionality rather than binutils version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/07/2020 13:48, Bruce Richardson: > Rather than checking the binutils version number, which can lead to > unnecessary disabling of AVX512 if fixes have been backported to distro > versions, we can instead check the output of "as" from binutils to see if > it is correct. > > The check in the script uses the minimal assembly reproduction code posted > to the public bug tracker for gcc/binutils for those issues [1]. If the > binutils bug is present, the instruction parameters - specifically the > displacement parameter - will be different in the disassembled output > compared to the input. Therefore the check involves assembling a single > instruction and disassembling it again, checking that the two match. > > [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90028 > > Signed-off-by: Bruce Richardson > Tested-by: Harry van Haaren > > --- > V3: > - Use mktemp to create a temporary file rather than place object file in > build folder. Use trap to ensure temp file deletion on exit. > > V2: > - Renamed "as_ok" variable to "binutils_ok" for readability > - Removed one test case from the script because even though two DPDK bugs > were filed, the one binutils bug is the root cause, and a single commit > fixes them both > - Changed message() to warning() in the printout Applied, thanks