From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4CD4A0559; Tue, 17 Mar 2020 10:31:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A32561C037; Tue, 17 Mar 2020 10:31:38 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 72F4DCF3 for <dev@dpdk.org>; Tue, 17 Mar 2020 10:31:37 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 086895C01E6; Tue, 17 Mar 2020 05:31:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 17 Mar 2020 05:31:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=VUomo3K/xM/CpF0A/TBDu4pj4SnSKRfmbnZN7s9pyHE=; b=j+rEuYiP5k17 SLrhBpAuyNkaVEEZpd/EofbFXSfm4lL/sYQh8aTZPVfv+p2/dBAKW0Rzq9W6S1tr tZ1WScrW4Ek3+MB5Jjg1fkZOmnmlZkPfwM6XGY0GwDOSdGrnu0yNrR4GQ+7Yk/mm lpcfamlgb+aKM9JMfWGcmqvUUR2xwE4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=VUomo3K/xM/CpF0A/TBDu4pj4SnSKRfmbnZN7s9py HE=; b=nrW4Gh172ZyPhF291MOVK/AIjTb53q4NFs3djoQNeOPKxM1CZfQy3parP kC1OoFPTXpRiI5AiChaeqWOdG7ujm+z18eJPQpwOtOpRvQwXqMwknUTdYmvSJYY0 k/OxVsvtowLAdpo3Mhb6DxKVaqeivF/McT+JdlBxBwnVRWDMyYeFPsSB1ieSTEV1 KzSffdSoorSmWznPiPXQvsz/6seFeCGVdpNrvprjW88zqNTy3XkvMQz9AxemZdPv 1inM6+CErH3ThM+F/jBCMccBCQrXyhfkB6mRwTOeCQBNSBH5jnboZnQlBytbSnUO BAGCGusbVKhOqwsZgi5jqzsO+fhFQ== X-ME-Sender: <xms:-JhwXqYsV1C5qR-etggn1OPI9C9nRhkZBlHZg-NYHFQOkSP2LnStNg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudefhedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:-JhwXvHBnzfl8iLuz4KRQbRQyR3ydsRGu67KRFYCTNkG9AjgSVac4Q> <xmx:-JhwXobKbvxKgXzDq0jtwbdq6gngPqVg_EMVL5e2Gs06-h6Y__hQQA> <xmx:-JhwXseUF0Za1FuCcO8P8U5Sjzn1vEYe9NEqRCm9T7383tiBpFOSFA> <xmx:-ZhwXpoil7RoQKrk6hR6enKTuoLMrai9jvv5lPIcLVQL8zipXRVUJA> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8D501306215A; Tue, 17 Mar 2020 05:31:35 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Pallavi Kadam <pallavi.kadam@intel.com> Cc: dev@dpdk.org, ranjit.menon@intel.com, talshn@mellanox.com, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com, narcisa.vasile@microsoft.com Date: Tue, 17 Mar 2020 10:31:34 +0100 Message-ID: <10706758.F0gNSz5aLb@xps> In-Reply-To: <20200317004802.11424-3-pallavi.kadam@intel.com> References: <20200317004802.11424-1-pallavi.kadam@intel.com> <20200317004802.11424-3-pallavi.kadam@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/2] build: add module definitions and pci lib support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 17/03/2020 01:48, Pallavi Kadam: > Added mman functions to eal exports list. [...] > --- a/lib/librte_eal/rte_eal_exports.def > +++ b/lib/librte_eal/rte_eal_exports.def This file is generated. Only the .map can be updated. > @@ -7,3 +7,5 @@ EXPORTS > rte_eal_remote_launch > rte_log > rte_vlog > + mmap > + munmap These functions should not be exported for Linux. And in general, I think it would be better to state what is the memory management strategy on Windows first. Maybe we will need to use a different abstraction.