From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id A97A7C45E for ; Wed, 15 Jun 2016 11:32:41 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id f126so13303694wma.1 for ; Wed, 15 Jun 2016 02:32:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=2+ATjmQT776GcKcF8IdCPiWfqfgfdPr+CioC4JsH5mY=; b=SjNThHqsbfJuA1vmNPKoHOuwc6ALzjM7Dmt2XDkKHPFocuW6rvZ0Ak4VDm8gUFzqqD O0nD3FheUUBCLPmqGB0LCdxvZhGBXN8c2aUUHMxFTUIZtB8ieu5H3DUbIIfq6Oeb2N9j M22/CNCz/iuy7/jDUg2dMLxCqSyPMCCU6jCip7DbAbMHNqyx8hBr1Mb0Yla49FQS2f6R cbm7z93ixGiO8rhnhFm1xY8flouFLqHnOsRW4fcznlRLlopIsoXd5h3+tG0xNJwLR4cO nndK8g8GHUgSIHQXk+7f/JinMPCVilc1t2gmmjp1Qo4M3QZk4XlZoD1G9QU2ysZwPjaP yFhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=2+ATjmQT776GcKcF8IdCPiWfqfgfdPr+CioC4JsH5mY=; b=L7P3zguE5Ikys+VWCsYDj4oz6vDsAh0JfbbvzRPEQVQpHviVMohLnxSE1E+/rt+Zf4 falLnLcCmELoXAD1i14kgn+yGFoUw28vLNQlpVAjqzuP0WLxgDFXJgMznEd3CO5cyHDg /YFxIQ9b51f+NRsE0EzP/qGDYZzxrKXmf1dWNTJYIro21kLxYgGpFL6ps5x9H9zHKBtm cMUKXldb23sIQcWvvkcEEE1tYoeV5NHpqNHRW9GYSrJ4kgvexG/039chamWyXbbm3Tnj VcXoS4nfP8bunh+bDN3oWXFHsrdsPgJSg7e8jdWoARysO7M1qWbDyKj1taSXqjwU54Lw sr9g== X-Gm-Message-State: ALyK8tKgeLiUSgx7hyOAo33WZIaD/7DVLOp5Q5tKWqGL3icaWx+5rX8Is1STlqqWAuuB8HGx X-Received: by 10.28.232.24 with SMTP id f24mr9337867wmh.3.1465983161345; Wed, 15 Jun 2016 02:32:41 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id x83sm3218469wmx.9.2016.06.15.02.32.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jun 2016 02:32:40 -0700 (PDT) From: Thomas Monjalon To: "Mcnamara, John" Cc: "Pattan, Reshma" , dev@dpdk.org Date: Wed, 15 Jun 2016 11:32:39 +0200 Message-ID: <10727658.5TGes6emps@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1465575534-23605-1-git-send-email-reshma.pattan@intel.com> <3000552.2jYBPTLpa9@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v9 5/8] pdump: add new library for packet capturing support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2016 09:32:41 -0000 2016-06-15 09:05, Mcnamara, John: > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > 2016-06-14 10:38, Reshma Pattan: > > > The new librte_pdump library is added for packet capturing support. > > > > > > > And more importantly, we need a doc in the prog guide. > > > > Hi Thomas, > > The Programmers Guide update is in another part of the patchset. Can we get some clarification on the requirements for documentation within patchset? > > Should all documentation related to a feature be in the patch for the feature? From your recent comments on patches it looks like that is the way you prefer it. That is fine but there is some confusion because it seems that wasn't always a requirement in the past so it would be best to clarify, and preferably document this. When reading a patch (including after integration in the git tree), it is easier to understand when having the related doc with the code changes. > Also, it makes it a bit harder for the documentation maintainer (me in this case) to see doc changes within patches and to ack just the doc part. From a documentation maintainer point of view it would be best to have any, non-trivial, doc changes in a separate patch. I understand your concern. But you cannot assume every doc changes will be properly highlighted in the headline. I think you need to filter patches based on a content pattern: +++ b/doc/guides/