From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0C6A43C5E; Wed, 6 Mar 2024 15:01:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D578E40A6D; Wed, 6 Mar 2024 15:01:35 +0100 (CET) Received: from fhigh5-smtp.messagingengine.com (fhigh5-smtp.messagingengine.com [103.168.172.156]) by mails.dpdk.org (Postfix) with ESMTP id 9CB1A40276; Wed, 6 Mar 2024 15:01:34 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.nyi.internal (Postfix) with ESMTP id D5EF61140089; Wed, 6 Mar 2024 09:01:33 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 06 Mar 2024 09:01:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1709733693; x=1709820093; bh=Pmp5KbMP79FPyr9DPHtI6KrUr2x7lXbp6CEf4Gg1Tkw=; b= JBxTgEyeHJi21Vh1zu1iHKyq9XADxKH2UA0vSp3Bc0XQgJ75uTLcFiUeogc+FsV3 APX11NaDNOkDZDP0OcElPkzd57xUtJ8vU+uOloPNPKlOLm3x9Q3duOUJi6f+D7UV uGVMRSsUSl/4laM7LqaUpmv7PVKfAFzugCSW/U0JcxkULoSoiplN7xjbGKnNX4W8 wyotJ9h2hW0AzivvgouiTagFkQp90L7IWYeLOJ0LRaONdTFfhVrew3J+y2k+D/PB HNCt+tFkJ5XMCmUP3B0ZNVIlj61LP9CW8q9H0BoiCecaafYhMcDV2gBo2K1C0J3y qJGr7dJrwwhgPa1ECQH+AQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1709733693; x= 1709820093; bh=Pmp5KbMP79FPyr9DPHtI6KrUr2x7lXbp6CEf4Gg1Tkw=; b=d EzqRnhS9hVaf+nFbC+mCAh2vdsOObchVggvgAcKuZYXORrlJhfl2EurTJ8b+XPqI /mQ5hJ+li9NvQc3xMUV+8jjQaqPWkX0ay8woZoux24PV1KNnh3CPxut1UIy81oGF LWtcmNEOCLXcuaGmHSp+jwsxmcL0OOSxFOuPSMLnFE9APxQKp1SmjkNUfIllATpr /LTRPK8F5dVNGAc1f8UkaGy9KoYhC6ziyIDziy9g41ljuWbCepg0k31mGuNdtfi6 x5qz087N4uG1MG5tpuyM+jIBYt3MxxbcFaUNO38fKtyXqsqsOuQsbySeaREiOfMn 7cFpmqlKF7V26e0thD4Ng== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledriedugdehiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Mar 2024 09:01:32 -0500 (EST) From: Thomas Monjalon To: Mingjin Ye Cc: dev@dpdk.org, qiming.yang@intel.com, yidingx.zhou@intel.com, stable@dpdk.org, Anatoly Burakov Subject: Re: [PATCH] bus/vdev: fix devargs memory leak Date: Wed, 06 Mar 2024 15:01:31 +0100 Message-ID: <10756368.zapYfy813O@thomas> In-Reply-To: <20230901072409.741847-1-mingjinx.ye@intel.com> References: <20230901072409.741847-1-mingjinx.ye@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 01/09/2023 09:24, Mingjin Ye: > When a device is created by a secondary process, an empty devargs is > temporarily generated and bound to it. This causes the device to not > be associated with the correct devargs, and the empty devargs are not > released when the resource is freed. > > This patch fixes the issue by matching the devargs when inserting a > device in secondary process. > > Fixes: dda987315ca2 ("vdev: make virtual bus use its device struct") > Fixes: a16040453968 ("eal: extract vdev infra") > Cc: stable@dpdk.org > > Signed-off-by: Mingjin Ye > --- > +static struct rte_devargs * > +vdev_devargs_lookup(const char *name) > +{ > + struct rte_devargs *devargs; > + char dev_name[32]; > + > + RTE_EAL_DEVARGS_FOREACH("vdev", devargs) { > + devargs->bus->parse(devargs->name, &dev_name); > + if (strcmp(dev_name, name) == 0) { > + VDEV_LOG(INFO, "**Devargs matched %s", dev_name); The beginning of the log does not need such attention characters. Removing while merging. With Acked-by: Anatoly Burakov Applied, thanks.