From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 027FB43D18; Thu, 21 Mar 2024 18:22:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C23342830; Thu, 21 Mar 2024 18:22:19 +0100 (CET) Received: from fout3-smtp.messagingengine.com (fout3-smtp.messagingengine.com [103.168.172.146]) by mails.dpdk.org (Postfix) with ESMTP id 96D33427E1 for ; Thu, 21 Mar 2024 18:22:18 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfout.nyi.internal (Postfix) with ESMTP id DF9BE1380136; Thu, 21 Mar 2024 13:22:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 21 Mar 2024 13:22:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1711041737; x=1711128137; bh=1uhtP9nOI874Kyx+Fbsvt2O0Tuz1pxcntPeeBVwGMRQ=; b= kTdfD0EOx3MMOJ7tvQSJBNsRELEtqUyHGrABWFBAsOK/4BLO1SNs3ehGL1QDmMir dJyQcQTfof6SielLxnvM8zjfvh1rxtZqZrC3eXeTtgunNyjJ2QY4aZIMbMPcT5oh nYqS7GBJ9VS2bg0OhcGMwwAMfPXYjEdcMapQoIfkpQHWQKWhInXHbMV6yZjGmb8O QyKBLY+VseZTTu56fH7J927iaebwDdup68MGGN1wqJeZ/2fswl850NHKFwTjeKwL NNPARbiuyI7lGkZStXaHcDutiErd7HJGKT/fBZbmhixXud+FyodGKn9NIE2HNIAs dHAb7TdpTboNmfvjPyFUwQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1711041737; x= 1711128137; bh=1uhtP9nOI874Kyx+Fbsvt2O0Tuz1pxcntPeeBVwGMRQ=; b=t xLzQpEmMQlIQI0eBMKyIW20eWF7meXyhqWqQJ6i+xtU0qiL38h6sATapgaN6VWy5 ExUZ89Fwg/kJGcpY0oX1RGwCxU38+TynRZH1bGGKX4wKvRnSUwr5bzjTG1vPW3Bh i8NB72ey22OBw4X9QAfJYTsxnhdzoyitRIjLSqji1r9SDh4VbsV3o8S7WW8J0kcS hx66OJurifJzAWkaDKhZhYR3CoZM0J+Xh0+QtUJdYBUZS86f+HirX8lCYEirrUfT zkGX5O9j/wBUt4HCpWIhK7KSl7tNb19rZOY6R4fvhhF2mtKlBDUybgNBDwB0eprx zxJr6uec9iQQAd+8s7gTQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrleejgdefkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeuveejffejgedtgeegkefg vdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 21 Mar 2024 13:22:16 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: Bruce Richardson , Dmitry Kozlyuk , dev@dpdk.org, david.marchand@redhat.com, olivier.matz@6wind.com Subject: Re: [dpdk-dev] [PATCH] eal: add option to put timestamp on console output Date: Thu, 21 Mar 2024 18:22:14 +0100 Message-ID: <10764230.zapYfy813O@thomas> In-Reply-To: <20201019082528.78e78811@hermes.local> References: <20200814173441.23086-1-stephen@networkplumber.org> <8528402.suE0oRMLcd@thomas> <20201019082528.78e78811@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 19/10/2020 17:25, Stephen Hemminger: > On Mon, 19 Oct 2020 16:11:19 +0200 > Thomas Monjalon wrote: > > > There was no ack or conclusion for this patch. > > > > 17/08/2020 17:11, Stephen Hemminger: > > > On Mon, 17 Aug 2020 11:37:40 +0100 > > > Bruce Richardson wrote: > > > > > > > On Fri, Aug 14, 2020 at 12:20:28PM -0700, Stephen Hemminger wrote: > > > > > On Fri, 14 Aug 2020 22:09:11 +0300 > > > > > Dmitry Kozlyuk wrote: > > > > > > > > > > > On Fri, 14 Aug 2020 11:45:49 -0700, Stephen Hemminger wrote: > > > > > > > On Fri, 14 Aug 2020 21:39:29 +0300 > > > > > > > Dmitry Kozlyuk wrote: > > > > > > [...] > > > > > > > FreeBsd doesn't go through the same log code. > > > > > > > > > > > > Then --log-timestamp shouldn't appear on FreeBSD if it's unsupported. > > > > > > > > > > Was using same ifdef that is already there. There are several options already > > > > > (like syslog facility) which do nothing on FreeBSD anyway. > > > > > > > > > While that is correct, I think that we really should support this on > > > > FreeBSD also, since I don't think there is any technical reason we can't do > > > > so, right? Even a sub-optimal solution where the timestamp write and log > > > > write are non-atomic would be better than nothing. > > > > > > > > /Bruce > > > > > > FreeBSD now just uses default log stream (stdout). > > > Linux has log stream to syslog and stdout. > > > > > > There is nothing Linux specific in the old or new code. > > > The Linux code could just be moved to common, and both could use it. > > > That is a separate patch, and someone with expertise and build setup for FreeBSD needs to do it. > > > > > Lets fix FreeBSD to use common code for logging, then timestamp option can be added? OK