From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF727A0562; Mon, 3 May 2021 23:20:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F3F840150; Mon, 3 May 2021 23:20:46 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 446044014E for ; Mon, 3 May 2021 23:20:45 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 244021A2D; Mon, 3 May 2021 17:20:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 03 May 2021 17:20:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= WDFELyosUmOpgLzLyIa7nmg4dyt7WsF4zNEY6rAwuTw=; b=Q0LC1noVIxtxH1cK JQidIwvr7Ibqt4R2i1V6WTmMVsjh6xohbF4/v/KYgf18Yy83AjsB72HC0V1gh/Ne 4N08cC28gXn8ozwiKi+UJBZcuV+wA53UlYC0XmMzzbtvbS7+W84uWC3ukTL0tDti KeMttrjJUbudhTffB+VlqLmKNwLsCxsfiK3VTntQztFHT6+jLe5xog/BOwTlOtLB BKujrYCOXnHsFPq+yhumCnbAl0prdH26quw1Dz+q47kgGYV9RdZozIbHpQ+PBLgx st+X+Z7q5L7XA00Rs2GPikVh2sKKDKPDA4tOJzpWF9C0UZ6wUjA0ddJbRixundgW p580bw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=WDFELyosUmOpgLzLyIa7nmg4dyt7WsF4zNEY6rAwu Tw=; b=FGoRs/VdHU2MCR65a0VUsvzS5KZLqiAmsQEwabSFX6/qW4vPYyQD+jAkS rRtLHbsznS5ecFnRgBQHrN5eGuFnWLL9Q4sD6ErkaEgPJ3LEE6gzpmFlwJxHs1Wa Z6+B3gQIN1iYx6Ny5Umk9WJ38WKxWf6x4o3LcLLQ6MHPX0qOhWELGeSzpQrE83dc 65S0wTr0AwAmTDQ35sZ2hGeqAHuYXHBZ5XYU29za2sWPJik9tq2dceHHMetDDqPx iGC6qqo789POryZpyEtWye3R9IY/lFYnH53QaQzjokFd/plIyCPYEvddCCbn406Z jkXWhUtX47ozvjpl/1b23EMB1KKww== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdefgedgudeivdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 3 May 2021 17:20:42 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, kevin.laatz@intel.com, sunil.pai.g@intel.com, jiayu.hu@intel.com Date: Mon, 03 May 2021 23:20:40 +0200 Message-ID: <10801772.08G8JL9ftu@thomas> In-Reply-To: <20210430150637.362610-5-bruce.richardson@intel.com> References: <20210318182042.43658-1-bruce.richardson@intel.com> <20210430150637.362610-1-bruce.richardson@intel.com> <20210430150637.362610-5-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 04/12] raw/ioat: add explicit padding to descriptor struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/04/2021 17:06, Bruce Richardson: > Add an explicit padding field to the end of the descriptor structure so > that when the batch descriptor is defined on the stack for perform-ops, the > unused space is all zeroed appropriately. > > Signed-off-by: Bruce Richardson > --- > --- a/drivers/raw/ioat/rte_ioat_rawdev_fns.h > +++ b/drivers/raw/ioat/rte_ioat_rawdev_fns.h > - /* 28 bytes of padding here */ > + uint16_t intr_handle; /* completion interrupt handle */ This is more than padding. Does it deserve its own commit? > + > + /* remaining 26 bytes are reserved */ > + uint16_t __reserved[13]; > } __rte_aligned(64);