Re: [dpdk-dev] [PATCH 1/4] eal: provide functions to access PCI config

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-07-08 09:11, Stephen Hemminger:
> On Wed, 8 Jul 2015 15:04:16 +0000
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 
> > 2015-07-07 17:08, Stephen Hemminger:
> > > --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> > > +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> > > @@ -98,3 +98,8 @@ DPDK_2.0 {
> > >  
> > >         local: *;
> > >  };
> > > +
> > > +DPDK_2.1 {
> > > +       rte_eal_pci_read_config;
> > > +       rte_eal_pci_write_config;
> > > +};  
> > 
> > DPDK_2.0 is missing to make 2.1 node inheriting from 2.0 one.
> 
> Do you mean that it is ok to add functions but keep same ABI version?

No. It's explained there:
	http://dpdk.org/browse/dpdk/tree/doc/guides/guidelines/versioning.rst#n209
"
   DPDK_2.1 {
        global:
        rte_acl_create;

   } DPDK_2.0;

The addition of the new block tells the linker that a new version node is
available (DPDK_2.1), which contains the symbol rte_acl_create, and inherits the
symbols from the DPDK_2.0 node.
"