From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com
 [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 90CEA3B5
 for <dev@dpdk.org>; Wed,  8 Jul 2015 18:35:56 +0200 (CEST)
Received: by wiwl6 with SMTP id l6so350212192wiw.0
 for <dev@dpdk.org>; Wed, 08 Jul 2015 09:35:56 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=k3MtxM16sl8ozsmKVQo1+BjUZ/29YxuV/2PHz43YkN0=;
 b=c6wekKR4OSZi61GlDWgbqky39/eAbZUJTQd14/GGQELmBm8gaZAHn53Ixdyg1lki0a
 vA9E/LUHNIrbgKoZ2Q9ep109meJFYXLUP/uUhP0sztEvLWnmQIJlfOqVFq9BiqjcL4v3
 2qhuKjiv7XJuIzJC1J359hfvsdcQtfPcS3V5fni335F5uxvKgwk5vSm4HsTC3B1cPBjj
 5Q8RbObuZD4063u0hpCQAe+y90WtytkNkxpwY4Lo4Ru6xQnwUT9+05dI0qOvaJX9Zjbb
 Vz7hQAd37ni4lez4R8kqH9Qn3sAV2iLXPIG7HEiMzESRTkLoo9LQgqkK2zJjEY22oKwj
 EaXw==
X-Gm-Message-State: ALoCoQmAJPuPYHxCQ5jZUXepyvDot7Ks6s+eCAKNU1YO///pDN3CSrVyBrM7KC4K9bm48GEosN03
X-Received: by 10.181.13.230 with SMTP id fb6mr73430554wid.47.1436373356402;
 Wed, 08 Jul 2015 09:35:56 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id j7sm4309257wjz.11.2015.07.08.09.35.55
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 08 Jul 2015 09:35:55 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 08 Jul 2015 18:34:44 +0200
Message-ID: <10804961.SkRqr2DsGC@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <20150708091159.78e2998a@urahara>
References: <1436314095-21574-1-git-send-email-stephen@networkplumber.org>
 <d35efa226d95495e804181b2246063d2@HQ1WP-EXMB11.corp.brocade.com>
 <20150708091159.78e2998a@urahara>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH 1/4] eal: provide functions to access PCI
	config
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jul 2015 16:35:56 -0000

2015-07-08 09:11, Stephen Hemminger:
> On Wed, 8 Jul 2015 15:04:16 +0000
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 
> > 2015-07-07 17:08, Stephen Hemminger:
> > > --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> > > +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> > > @@ -98,3 +98,8 @@ DPDK_2.0 {
> > >  
> > >         local: *;
> > >  };
> > > +
> > > +DPDK_2.1 {
> > > +       rte_eal_pci_read_config;
> > > +       rte_eal_pci_write_config;
> > > +};  
> > 
> > DPDK_2.0 is missing to make 2.1 node inheriting from 2.0 one.
> 
> Do you mean that it is ok to add functions but keep same ABI version?

No. It's explained there:
	http://dpdk.org/browse/dpdk/tree/doc/guides/guidelines/versioning.rst#n209
"
   DPDK_2.1 {
        global:
        rte_acl_create;

   } DPDK_2.0;

The addition of the new block tells the linker that a new version node is
available (DPDK_2.1), which contains the symbol rte_acl_create, and inherits the
symbols from the DPDK_2.0 node.
"