* [dpdk-dev] [PATCH v2] kni:fix build failure as "ndo_change_mtu_rh74" not found in RHEL8
@ 2018-12-19 7:07 Xiao Liang
2018-12-19 7:07 ` Xiao Liang
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Xiao Liang @ 2018-12-19 7:07 UTC (permalink / raw)
To: dev; +Cc: xiliang
'ndo_change_mtu_rh74' was changed to 'ndo_change_mtu' in RHEL8.
Build error log:
/home/dpdk-18.11/kernel/linux/kni/compat.h:107:24: error: ‘const struct
net_device_ops’ has no member named ‘ndo_change_mtu_rh74’; did you mean
‘ndo_change_mtu’?
#define ndo_change_mtu ndo_change_mtu_rh74
^~~~~~~~~~~~~~~~~~~
Signed-off-by: Xiao Liang <xiliang@redhat.com>
---
kernel/linux/kni/compat.h | 3 ++-
kernel/linux/kni/ethtool/igb/kcompat.h | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
index 5aadebbcd..bc81d0c8d 100644
--- a/kernel/linux/kni/compat.h
+++ b/kernel/linux/kni/compat.h
@@ -103,7 +103,8 @@
#endif
#if (defined(RHEL_RELEASE_CODE) && \
- (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)))
+ (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \
+ (RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)))
#define ndo_change_mtu ndo_change_mtu_rh74
#endif
diff --git a/kernel/linux/kni/ethtool/igb/kcompat.h b/kernel/linux/kni/ethtool/igb/kcompat.h
index ae1b53093..2681be684 100644
--- a/kernel/linux/kni/ethtool/igb/kcompat.h
+++ b/kernel/linux/kni/ethtool/igb/kcompat.h
@@ -3930,7 +3930,8 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
#endif
#if (defined(RHEL_RELEASE_CODE) && \
- (RHEL_RELEASE_VERSION(7, 5) <= RHEL_RELEASE_CODE))
+ (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \
+ (RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)))
#define ndo_change_mtu ndo_change_mtu_rh74
#endif
--
2.17.2
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH v2] kni:fix build failure as "ndo_change_mtu_rh74" not found in RHEL8
2018-12-19 7:07 [dpdk-dev] [PATCH v2] kni:fix build failure as "ndo_change_mtu_rh74" not found in RHEL8 Xiao Liang
@ 2018-12-19 7:07 ` Xiao Liang
2018-12-19 13:26 ` Ferruh Yigit
2018-12-19 13:47 ` Ferruh Yigit
2 siblings, 0 replies; 6+ messages in thread
From: Xiao Liang @ 2018-12-19 7:07 UTC (permalink / raw)
To: dev; +Cc: xiliang
'ndo_change_mtu_rh74' was changed to 'ndo_change_mtu' in RHEL8.
Build error log:
/home/dpdk-18.11/kernel/linux/kni/compat.h:107:24: error: ‘const struct
net_device_ops’ has no member named ‘ndo_change_mtu_rh74’; did you mean
‘ndo_change_mtu’?
#define ndo_change_mtu ndo_change_mtu_rh74
^~~~~~~~~~~~~~~~~~~
Signed-off-by: Xiao Liang <xiliang@redhat.com>
---
kernel/linux/kni/compat.h | 3 ++-
kernel/linux/kni/ethtool/igb/kcompat.h | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
index 5aadebbcd..bc81d0c8d 100644
--- a/kernel/linux/kni/compat.h
+++ b/kernel/linux/kni/compat.h
@@ -103,7 +103,8 @@
#endif
#if (defined(RHEL_RELEASE_CODE) && \
- (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)))
+ (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \
+ (RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)))
#define ndo_change_mtu ndo_change_mtu_rh74
#endif
diff --git a/kernel/linux/kni/ethtool/igb/kcompat.h b/kernel/linux/kni/ethtool/igb/kcompat.h
index ae1b53093..2681be684 100644
--- a/kernel/linux/kni/ethtool/igb/kcompat.h
+++ b/kernel/linux/kni/ethtool/igb/kcompat.h
@@ -3930,7 +3930,8 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
#endif
#if (defined(RHEL_RELEASE_CODE) && \
- (RHEL_RELEASE_VERSION(7, 5) <= RHEL_RELEASE_CODE))
+ (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \
+ (RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)))
#define ndo_change_mtu ndo_change_mtu_rh74
#endif
--
2.17.2
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v2] kni:fix build failure as "ndo_change_mtu_rh74" not found in RHEL8
2018-12-19 7:07 [dpdk-dev] [PATCH v2] kni:fix build failure as "ndo_change_mtu_rh74" not found in RHEL8 Xiao Liang
2018-12-19 7:07 ` Xiao Liang
@ 2018-12-19 13:26 ` Ferruh Yigit
2018-12-19 13:28 ` Ferruh Yigit
2018-12-19 13:47 ` Ferruh Yigit
2 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2018-12-19 13:26 UTC (permalink / raw)
To: Xiao Liang, dev; +Cc: Kiran Kumar
On 12/19/2018 7:07 AM, Xiao Liang wrote:
> 'ndo_change_mtu_rh74' was changed to 'ndo_change_mtu' in RHEL8.
>
> Build error log:
> /home/dpdk-18.11/kernel/linux/kni/compat.h:107:24: error: ‘const struct
> net_device_ops’ has no member named ‘ndo_change_mtu_rh74’; did you mean
> ‘ndo_change_mtu’?
> #define ndo_change_mtu ndo_change_mtu_rh74
There is already a patch for it:
https://patches.dpdk.org/patch/48343/
But that one doesn't cover igb, so I suggest to go with this one.
>
> ^~~~~~~~~~~~~~~~~~~
> Signed-off-by: Xiao Liang <xiliang@redhat.com>
<...>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] kni:fix build failure as "ndo_change_mtu_rh74" not found in RHEL8
2018-12-19 13:26 ` Ferruh Yigit
@ 2018-12-19 13:28 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2018-12-19 13:28 UTC (permalink / raw)
To: Xiao Liang, dev; +Cc: Kiran Kumar, Mohammed Gamal
On 12/19/2018 1:26 PM, Ferruh Yigit wrote:
> On 12/19/2018 7:07 AM, Xiao Liang wrote:
>> 'ndo_change_mtu_rh74' was changed to 'ndo_change_mtu' in RHEL8.
>>
>> Build error log:
>> /home/dpdk-18.11/kernel/linux/kni/compat.h:107:24: error: ‘const struct
>> net_device_ops’ has no member named ‘ndo_change_mtu_rh74’; did you mean
>> ‘ndo_change_mtu’?
>> #define ndo_change_mtu ndo_change_mtu_rh74
>
> There is already a patch for it:
> https://patches.dpdk.org/patch/48343/
>
> But that one doesn't cover igb, so I suggest to go with this one.
cc'ed correct person (Mohammed) this time.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] kni:fix build failure as "ndo_change_mtu_rh74" not found in RHEL8
2018-12-19 7:07 [dpdk-dev] [PATCH v2] kni:fix build failure as "ndo_change_mtu_rh74" not found in RHEL8 Xiao Liang
2018-12-19 7:07 ` Xiao Liang
2018-12-19 13:26 ` Ferruh Yigit
@ 2018-12-19 13:47 ` Ferruh Yigit
2019-01-14 13:03 ` Thomas Monjalon
2 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2018-12-19 13:47 UTC (permalink / raw)
To: Xiao Liang, dev
On 12/19/2018 7:07 AM, Xiao Liang wrote:
> 'ndo_change_mtu_rh74' was changed to 'ndo_change_mtu' in RHEL8.
>
> Build error log:
> /home/dpdk-18.11/kernel/linux/kni/compat.h:107:24: error: ‘const struct
> net_device_ops’ has no member named ‘ndo_change_mtu_rh74’; did you mean
> ‘ndo_change_mtu’?
> #define ndo_change_mtu ndo_change_mtu_rh74
>
> ^~~~~~~~~~~~~~~~~~~
> Signed-off-by: Xiao Liang <xiliang@redhat.com>
Suggested title: 'kni: fix build on RHEL 8'
And a request to backport:
Cc: stable@dpdk.org
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] kni:fix build failure as "ndo_change_mtu_rh74" not found in RHEL8
2018-12-19 13:47 ` Ferruh Yigit
@ 2019-01-14 13:03 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2019-01-14 13:03 UTC (permalink / raw)
To: Xiao Liang; +Cc: dev, Ferruh Yigit
19/12/2018 14:47, Ferruh Yigit:
> On 12/19/2018 7:07 AM, Xiao Liang wrote:
> > 'ndo_change_mtu_rh74' was changed to 'ndo_change_mtu' in RHEL8.
> >
> > Build error log:
> > /home/dpdk-18.11/kernel/linux/kni/compat.h:107:24: error: ‘const struct
> > net_device_ops’ has no member named ‘ndo_change_mtu_rh74’; did you mean
> > ‘ndo_change_mtu’?
> > #define ndo_change_mtu ndo_change_mtu_rh74
> >
> > ^~~~~~~~~~~~~~~~~~~
> > Signed-off-by: Xiao Liang <xiliang@redhat.com>
>
> Suggested title: 'kni: fix build on RHEL 8'
>
> And a request to backport:
> Cc: stable@dpdk.org
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-14 13:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-19 7:07 [dpdk-dev] [PATCH v2] kni:fix build failure as "ndo_change_mtu_rh74" not found in RHEL8 Xiao Liang
2018-12-19 7:07 ` Xiao Liang
2018-12-19 13:26 ` Ferruh Yigit
2018-12-19 13:28 ` Ferruh Yigit
2018-12-19 13:47 ` Ferruh Yigit
2019-01-14 13:03 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).