DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] Vmxnet3 pmd
@ 2014-08-13 10:13 Alex Markuze
  2014-08-13 16:58 ` Patel, Rashmin N
  2014-08-26  0:41 ` [dpdk-dev] [PATCH] vmxnet3: fix crash on stop Stephen Hemminger
  0 siblings, 2 replies; 4+ messages in thread
From: Alex Markuze @ 2014-08-13 10:13 UTC (permalink / raw)
  To: dev

Hi, I Have a simple dpdk app - basically a KNI interface with the dpdk
layer serving only as a pipeline.

This allows me to ping between vEth0 on different VM's works great with ixgbevf.
Now I moved to ESXi5.5 , Ubuntu14.4 VM (Dpdk 1.7).
When running the same code*  I've discovered that the polling doesn't
retrieve any packets after vEth0 gents an IP. I've resolved this issue
by removing the dev restart calls I had in the callback.

        //      rte_eth_dev_stop(port_id);
        //      ret = rte_eth_dev_start(port_id);

Is this a know issue? how can I report a BUG if its not.

Thanks
Alex.

*Except this line I needed to add to setup the TXQ.
tx_conf.txq_flags |= (ETH_TXQ_FLAGS_NOMULTSEGS | ETH_TXQ_FLAGS_NOOFFLOADS);

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] Vmxnet3 pmd
  2014-08-13 10:13 [dpdk-dev] Vmxnet3 pmd Alex Markuze
@ 2014-08-13 16:58 ` Patel, Rashmin N
  2014-08-26  0:41 ` [dpdk-dev] [PATCH] vmxnet3: fix crash on stop Stephen Hemminger
  1 sibling, 0 replies; 4+ messages in thread
From: Patel, Rashmin N @ 2014-08-13 16:58 UTC (permalink / raw)
  To: Alex Markuze, dev

Hi Alex,

This is known issue with dev_stop of vmxnet3_pmd. Vmxnet3_cmd_ring_release() routine calls rte_free(ring->buf_info), which should be reused instead. Because it's not being reallocated at dev_start, otherwise reallocation is needed. I've a patch that works for me, I'll submit it after some testing.

Thanks,
Rashmin

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Alex Markuze
Sent: Wednesday, August 13, 2014 3:14 AM
To: dev@dpdk.org
Subject: [dpdk-dev] Vmxnet3 pmd

Hi, I Have a simple dpdk app - basically a KNI interface with the dpdk layer serving only as a pipeline.

This allows me to ping between vEth0 on different VM's works great with ixgbevf.
Now I moved to ESXi5.5 , Ubuntu14.4 VM (Dpdk 1.7).
When running the same code*  I've discovered that the polling doesn't retrieve any packets after vEth0 gents an IP. I've resolved this issue by removing the dev restart calls I had in the callback.

        //      rte_eth_dev_stop(port_id);
        //      ret = rte_eth_dev_start(port_id);

Is this a know issue? how can I report a BUG if its not.

Thanks
Alex.

*Except this line I needed to add to setup the TXQ.
tx_conf.txq_flags |= (ETH_TXQ_FLAGS_NOMULTSEGS | ETH_TXQ_FLAGS_NOOFFLOADS);

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-dev] [PATCH] vmxnet3: fix crash on stop
  2014-08-13 10:13 [dpdk-dev] Vmxnet3 pmd Alex Markuze
  2014-08-13 16:58 ` Patel, Rashmin N
@ 2014-08-26  0:41 ` Stephen Hemminger
  2014-08-29 10:41   ` Thomas Monjalon
  1 sibling, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2014-08-26  0:41 UTC (permalink / raw)
  To: Alex Markuze; +Cc: dev

The cmd_ring_release can be called twice if queue has already
been released. This cause crash on shutdown.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>


--- a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c	2014-08-25 17:39:04.544119911 -0700
+++ b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c	2014-08-25 17:39:04.544119911 -0700
@@ -173,6 +173,7 @@ vmxnet3_cmd_ring_release(vmxnet3_cmd_rin
 		vmxnet3_cmd_ring_adv_next2comp(ring);
 	}
 	rte_free(ring->buf_info);
+	ring->buf_info = NULL;
 }
 
 void

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] vmxnet3: fix crash on stop
  2014-08-26  0:41 ` [dpdk-dev] [PATCH] vmxnet3: fix crash on stop Stephen Hemminger
@ 2014-08-29 10:41   ` Thomas Monjalon
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2014-08-29 10:41 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev

> The cmd_ring_release can be called twice if queue has already
> been released. This cause crash on shutdown.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> @@ -173,6 +173,7 @@ vmxnet3_cmd_ring_release(vmxnet3_cmd_rin
>  		vmxnet3_cmd_ring_adv_next2comp(ring);
>  	}
>  	rte_free(ring->buf_info);
> +	ring->buf_info = NULL;
>  }

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied for version 1.7.1.

Thanks
-- 
Thomas

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-08-29 10:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-13 10:13 [dpdk-dev] Vmxnet3 pmd Alex Markuze
2014-08-13 16:58 ` Patel, Rashmin N
2014-08-26  0:41 ` [dpdk-dev] [PATCH] vmxnet3: fix crash on stop Stephen Hemminger
2014-08-29 10:41   ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git