From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f182.google.com (mail-we0-f182.google.com
 [74.125.82.182]) by dpdk.org (Postfix) with ESMTP id C6488B373
 for <dev@dpdk.org>; Fri, 29 Aug 2014 12:37:47 +0200 (CEST)
Received: by mail-we0-f182.google.com with SMTP id w62so2016810wes.27
 for <dev@dpdk.org>; Fri, 29 Aug 2014 03:42:01 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=W09kSfLkOPiXboAnrtHM4hxchAbwrCzpRX5GJtYwu8M=;
 b=avtcc7hCq7enXQMDjitNDC6/bvXOT97VbQ+fTnE7A0n28+QExL4DT3vMBf2vC8Bje0
 tyrVsvupA6UIBgVfrL+YIGHySnX9OpDpQ1LSFCmj5+BbX9n8zyd7nKxIquUaBnkZOD4/
 pAU6/SZL+SdC1BsNCs+FCiDMCu1N6cRCm65jbmcrnBC58MWyd5PdEj11r549KWa+fJ9Y
 Z7EzaUZm4BKc431Omr/sEAaxpExYsXyiucdiiY1M96cRYStJzcesuu2xbbXSEZfm3o+P
 03mCnbKNdjr0lZCPIC461JPCnwivf60znu4AiiVamZwwjHm8o0QUZqGfpODpdaLdRO7D
 caYg==
X-Gm-Message-State: ALoCoQkOqCe3iaOBk/OsMF9n7pCVzHoSu8wHvdgvci5ulAEj1YpMcvFzAPkJs91GAeJQ2iDjhoks
X-Received: by 10.180.104.7 with SMTP id ga7mr2976848wib.36.1409308920932;
 Fri, 29 Aug 2014 03:42:00 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id lz1sm24905134wic.24.2014.08.29.03.41.59
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 29 Aug 2014 03:42:00 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 29 Aug 2014 12:41:55 +0200
Message-ID: <10841393.AHMXh0MRSo@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )
In-Reply-To: <20140825174102.3a0989f4@urahara>
References: <CAKfHP0V4xx3mwg0dYMDFcQOVdN1BfBzuHfnT59KKFVy9LAz70Q@mail.gmail.com>
 <20140825174102.3a0989f4@urahara>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vmxnet3: fix crash on stop
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Aug 2014 10:37:47 -0000

> The cmd_ring_release can be called twice if queue has already
> been released. This cause crash on shutdown.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> @@ -173,6 +173,7 @@ vmxnet3_cmd_ring_release(vmxnet3_cmd_rin
>  		vmxnet3_cmd_ring_adv_next2comp(ring);
>  	}
>  	rte_free(ring->buf_info);
> +	ring->buf_info = NULL;
>  }

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied for version 1.7.1.

Thanks
-- 
Thomas