From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D9756A00BE;
	Wed, 30 Oct 2019 07:28:56 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 4CA6D1BEB4;
	Wed, 30 Oct 2019 07:28:56 +0100 (CET)
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 6BAA21BEB3
 for <dev@dpdk.org>; Wed, 30 Oct 2019 07:28:55 +0100 (CET)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id DECEDB00056;
 Wed, 30 Oct 2019 06:28:53 +0000 (UTC)
Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com
 (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 30 Oct
 2019 06:28:47 +0000
To: Thomas Monjalon <thomas@monjalon.net>, Slava Ovsiienko
 <viacheslavo@mellanox.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, Matan Azrad <matan@mellanox.com>,
 "olivier.matz@6wind.com" <olivier.matz@6wind.com>, Ori Kam
 <orika@mellanox.com>
References: <1571922495-4588-1-git-send-email-viacheslavo@mellanox.com>
 <d19ddcbb-8ea5-17d8-efa0-e9e8305b6671@solarflare.com>
 <AM4PR05MB3265862E508CE480DE9C7462D2610@AM4PR05MB3265.eurprd05.prod.outlook.com>
 <5596453.zqmvSB3bmi@xps>
From: Andrew Rybchenko <arybchenko@solarflare.com>
Message-ID: <1086207f-00f0-ed25-f43a-ba1ea83c37cb@solarflare.com>
Date: Wed, 30 Oct 2019 09:28:43 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <5596453.zqmvSB3bmi@xps>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
X-Originating-IP: [91.220.146.112]
X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To
 ukex01.SolarFlarecom.com (10.17.10.4)
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-25010.003
X-TM-AS-Result: No-0.270000-8.000000-10
X-TMASE-MatchedRID: cgbqQT5W8hfmLzc6AOD8DfHkpkyUphL9biA4btzHF9tUjspoiX02F3im
 o7zurlpwuw9uO/ExCm933rGBcrO9pGGHMrV83fgZ3N5FQzZaRXucqlCdrhyhQF70lsqJNmcejnT
 NYcTGP0qwSD+bLJNUXZakfzQTH59NwBhAKrgQyUxswYo64ufkVben4cs4BHh8myiLZetSf8nJ4y
 0wP1A6APkvV+z371TK5MIx11wv+COrvtPKKgnMGGLU9N/XHSv6YSfmgMBhApnuSzlwzs8IALY+A
 +SNPiuTomSkHLm1Fh4fw8LI6jDbo/CCNM4JQmGI0B6Qv/jTSSLJqeV8p/xw84VyAlz5A0zC7xsm
 i8libwVi6nHReNJA8sM4VWYqoYnhVga+6uzn7TBWXGvUUmKP2w==
X-TM-AS-User-Approved-Sender: Yes
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10-0.270000-8.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-25010.003
X-MDID: 1572416934-k9MgnezC2MNN
Subject: Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/29/19 9:30 PM, Thomas Monjalon wrote:
> 29/10/2019 18:19, Slava Ovsiienko:
>> From: Andrew Rybchenko <arybchenko@solarflare.com>
>>>> --- a/doc/guides/rel_notes/deprecation.rst
>>>> +++ b/doc/guides/rel_notes/deprecation.rst
>>>> +* ethdev: DEV_TX_OFFLOAD_MATCH_METADATA will be removed, static
>>>> +metadata
>>>> +  mbuf field will be removed in 20.02, metadata feature will use
>>>> +dynamic mbuf
>>>> +  field and flag instead.
>>>> +
>>> Isn't it breaking stable API/ABI? Should target release be 20.11?
>> tx_metadata is in union, it should not be ABI break.
>> And we propose to remove tx_metadata at all in 19.11
>> and share the dynamic metadata field between Rx and Tx METAdata.
> Yes please, let's remove tx_metadata from mbuf now,
> while adding metadata dynamic field.
> I am sure nobody will complain that we sanitized this feature
> before releasing DPDK 19.11 LTS.

OK for me.