From: Thomas Monjalon <thomas@monjalon.net>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
Neil Horman <nhorman@tuxdriver.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
"Kovacevic, Marko" <marko.kovacevic@intel.com>,
"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] bitmap: deprecate and rename rte_bsf64
Date: Thu, 22 Nov 2018 23:44:50 +0100 [thread overview]
Message-ID: <10867117.EFarvljQJ7@xps> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB977258010CEBB04A@IRSMSX106.ger.corp.intel.com>
22/11/2018 19:56, Ananyev, Konstantin:
> > Rename rte_bsf64 to rte_bsf64_safe (this is a "safe" version in
> > that it prevents undefined behavior by checking if incoming
> > parameter is zero) and move it to common header.
>
> Probably a stupid one: why to rename?
> Why just not fix rte_bsf64 to make it work with zero value,
> and keep the same function name?
Because there are different parameters and returned value
than rte_bsf32.
In the next release, we will have rte_bsf64 function,
behaving as rte_bsf32.
This is explained in the deprecation notice.
[...]
> > +static inline int
> > +rte_bsf64_safe(uint64_t v, uint32_t *pos)
prev parent reply other threads:[~2018-11-22 22:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 12:05 [dpdk-dev] [PATCH 1/2] bitmap: remove useless code Anatoly Burakov
2018-11-21 12:05 ` [dpdk-dev] [PATCH 2/2] bitmap: deprecate and rename rte_bsf64 Anatoly Burakov
2018-11-22 17:04 ` Thomas Monjalon
2018-11-22 22:52 ` Thomas Monjalon
2018-11-22 18:56 ` Ananyev, Konstantin
2018-11-22 22:44 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10867117.EFarvljQJ7@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jasvinder.singh@intel.com \
--cc=john.mcnamara@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).