From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C1B542C8 for ; Wed, 28 Jun 2017 17:47:37 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jun 2017 08:47:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,276,1496127600"; d="scan'208";a="1165698977" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by fmsmga001.fm.intel.com with ESMTP; 28 Jun 2017 08:47:36 -0700 To: Shreyansh Jain , dev@dpdk.org Cc: hemant.agrawal@nxp.com References: <1497591668-3320-1-git-send-email-shreyansh.jain@nxp.com> <1497591668-3320-34-git-send-email-shreyansh.jain@nxp.com> From: Ferruh Yigit Message-ID: <108d2db3-8154-c108-13a7-722f861537af@intel.com> Date: Wed, 28 Jun 2017 16:47:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1497591668-3320-34-git-send-email-shreyansh.jain@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 33/38] net/dpaa: add support for flow control X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jun 2017 15:47:38 -0000 On 6/16/2017 6:41 AM, Shreyansh Jain wrote: > Signed-off-by: Hemant Agrawal > Signed-off-by: Shreyansh Jain <...> > static int > +dpaa_flow_ctrl_set(struct rte_eth_dev *dev, > + struct rte_eth_fc_conf *fc_conf) > +{ > + struct dpaa_if *dpaa_intf = dev->data->dev_private; > + struct rte_eth_fc_conf *net_fc; > + > + PMD_INIT_FUNC_TRACE(); > + > + if (!(dpaa_intf->fc_conf)) { > + dpaa_intf->fc_conf = rte_zmalloc(NULL, > + sizeof(struct rte_eth_fc_conf), MAX_CACHELINE); Should this be freed in rte_dpaa_remove() > + if (!dpaa_intf->fc_conf) { > + PMD_DRV_LOG(ERR, "unable to save flow control info"); > + return -ENOMEM; > + } > + } > + net_fc = dpaa_intf->fc_conf; > + <...>