* [dpdk-dev] [PATCH] bus/vdev: don't double space log messages
@ 2018-05-16 21:51 Stephen Hemminger
2018-05-17 9:33 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2018-05-16 21:51 UTC (permalink / raw)
To: gaetan.rivet; +Cc: dev, Stephen Hemminger
The VDEV_LOG() macro already adds a newline, don't duplicate.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/bus/vdev/vdev.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
index 9f576eb80f26..099b9ff85a70 100644
--- a/drivers/bus/vdev/vdev.c
+++ b/drivers/bus/vdev/vdev.c
@@ -142,7 +142,7 @@ vdev_probe_all_drivers(struct rte_vdev_device *dev)
name = rte_vdev_device_name(dev);
- VDEV_LOG(DEBUG, "Search driver %s to probe device %s\n", name,
+ VDEV_LOG(DEBUG, "Search driver %s to probe device %s", name,
rte_vdev_device_name(dev));
if (vdev_parse(name, &driver))
@@ -255,7 +255,7 @@ rte_vdev_init(const char *name, const char *args)
ret = vdev_probe_all_drivers(dev);
if (ret) {
if (ret > 0)
- VDEV_LOG(ERR, "no driver found for %s\n", name);
+ VDEV_LOG(ERR, "no driver found for %s", name);
/* If fails, remove it from vdev list */
devargs = dev->device.devargs;
TAILQ_REMOVE(&vdev_device_list, dev, next);
@@ -274,7 +274,7 @@ vdev_remove_driver(struct rte_vdev_device *dev)
const struct rte_vdev_driver *driver;
if (!dev->device.driver) {
- VDEV_LOG(DEBUG, "no driver attach to device %s\n", name);
+ VDEV_LOG(DEBUG, "no driver attach to device %s", name);
return 1;
}
@@ -482,7 +482,7 @@ vdev_probe(void)
continue;
if (vdev_probe_all_drivers(dev)) {
- VDEV_LOG(ERR, "failed to initialize %s device\n",
+ VDEV_LOG(ERR, "failed to initialize %s device",
rte_vdev_device_name(dev));
ret = -1;
}
--
2.17.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] bus/vdev: don't double space log messages
2018-05-16 21:51 [dpdk-dev] [PATCH] bus/vdev: don't double space log messages Stephen Hemminger
@ 2018-05-17 9:33 ` Ferruh Yigit
2018-05-20 23:20 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2018-05-17 9:33 UTC (permalink / raw)
To: Stephen Hemminger, gaetan.rivet; +Cc: dev
On 5/16/2018 10:51 PM, Stephen Hemminger wrote:
> The VDEV_LOG() macro already adds a newline, don't duplicate.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Fixes: d22fcb225c24 ("bus/vdev: change log type")
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] bus/vdev: don't double space log messages
2018-05-17 9:33 ` Ferruh Yigit
@ 2018-05-20 23:20 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-05-20 23:20 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev, Ferruh Yigit, gaetan.rivet
17/05/2018 11:33, Ferruh Yigit:
> On 5/16/2018 10:51 PM, Stephen Hemminger wrote:
> > The VDEV_LOG() macro already adds a newline, don't duplicate.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Fixes: d22fcb225c24 ("bus/vdev: change log type")
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-20 23:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-16 21:51 [dpdk-dev] [PATCH] bus/vdev: don't double space log messages Stephen Hemminger
2018-05-17 9:33 ` Ferruh Yigit
2018-05-20 23:20 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).