From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B480A00BE; Wed, 8 Jul 2020 11:10:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 08C2A1DB83; Wed, 8 Jul 2020 11:10:10 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id A93CA1DB6E for <dev@dpdk.org>; Wed, 8 Jul 2020 11:10:08 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id F026758052A; Wed, 8 Jul 2020 05:10:06 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 08 Jul 2020 05:10:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= H9rkEFkmgzQrzzs3cjpoee9k+32Kt6e7njbZ8zoNZH0=; b=mAzTbLdm8c2kln1R 0tsjT8FWs/obkF9hD2sTlrYCVWHbKgpZWUywEXZ2zNLpweAoCrdfBQ3ZiBRw8JZm ATPQ3ZNIjFcZi6IGHDUFbtL6rW6PNcUAHnHG27mHs3gQ5YXA/8kqVzYzikSvdIwK rD6C1xtdQWOpr7q8hBwZ3IQ9aJ+KxnCAAUbihDBogfWkmdS9rbqmdjgIbxQMK0Mg V092JA1BAyKAPoHe32dVkgyNx3Go6vl4bA9UHMFt+lMUP+Y4OBJa+cHoGK3+olmL wns24STTZ3ZVIjNpLznNAjXrbskDilWq1IXyPdeiyPDWwLz38lyCj7s7BYqxYWCq Dc0TkQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=H9rkEFkmgzQrzzs3cjpoee9k+32Kt6e7njbZ8zoNZ H0=; b=mJb0YT31A2A8ZACoxhxhiFlnGjI0f4nBBMgk6dBZMUtcUUOFqPgYpy4mn 9eg1qp0G9EmmCRc+q+JYHGVPRWZSKiR5kf/FHy9sDkIZZbkaU7+UDS4qqvgrKVJQ 8peJc9FvTnKei/E08kO2+6O39X/rZxFXV4bzNocgAmI5f7D71HRRKVKd+sXeglZf sF5Vxz5CGU1l9w/TPYuxbCQBSboFpPyZLGaZmVGeNH5W2YdMsYTDjGrntpQVirCE KfHF640vc2X9BqLemAirBDsHlr/jby9Mo1t1yo/bS5VPeIA6jOTuUWcwJsmsi/rH nnxav+7mxyzVrz0ExXg3hZcaiJjgg== X-ME-Sender: <xms:bo0FX8xxX9dZzQX0cAbxiq58NDdejTfclZw1Ig2ywyMSkIjmfL7CCA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudejgdduvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: <xmx:bo0FXwTY5ovYLjlcGXs9ZoJyNMwWZhHQ3-S2mypvmKwv2UM0ZQVw0Q> <xmx:bo0FX-XpbYpd7c-NQ5ySdfJIc_8J2vyzjIAQvgvIULpvCp0EAj5AdA> <xmx:bo0FX6jA7yruNjnwIGYaPLsVK-lISBPLyfboFTNZ0iYqqRuiPLvOOQ> <xmx:bo0FX0BrhqdJ_OUvFKBe9aq-riGqQeWXQ5npW-dLJItP6B5XoJgsww> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0055B328005D; Wed, 8 Jul 2020 05:10:04 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Fady Bader <fady@mellanox.com> Cc: dev@dpdk.org, tbashar@mellanox.com, talshn@mellanox.com, yohadt@mellanox.com, dmitry.kozliuk@gmail.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, olivier.matz@6wind.com Date: Wed, 08 Jul 2020 11:10:03 +0200 Message-ID: <10921482.ctDyDSMbzN@thomas> In-Reply-To: <20200708082525.28504-4-fady@mellanox.com> References: <20200610120040.17968-1-fady@mellanox.com> <20200708082525.28504-1-fady@mellanox.com> <20200708082525.28504-4-fady@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 3/3] eal/windows: librte_net build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 08/07/2020 10:25, Fady Bader: > --- /dev/null > +++ b/lib/librte_eal/windows/include/netinet/in.h > @@ -0,0 +1,25 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright 2020 Mellanox Technologies, Ltd > + */ As said previously, the license and copyright are not correct. Please keep the original copyright. Given there is no invention here, can we consider it can be re-licensed as BSD with your copyright? I think we can, but I prefer having this discussion openly. > +#ifndef _IN_H_ > +#define _IN_H_ > + > +#define IPPROTO_IP 0 > +#define IPPROTO_HOPOPTS 0 > +#define IPPROTO_IPV4 4 /* IPv4 encapsulation */ > +#define IPPROTO_IPIP IPPROTO_IPV4 /* for compatibility */ > +#define IPPROTO_TCP 6 > +#define IPPROTO_UDP 17 > +#define IPPROTO_IPV6 41 /* IP6 header */ > +#define IPPROTO_ROUTING 43 /* IP6 routing header */ > +#define IPPROTO_FRAGMENT 44 /* IP6 fragmentation header */ > +#define IPPROTO_GRE 47 /* General Routing Encap. */ > +#define IPPROTO_ESP 50 /* IP6 Encap Sec. Payload */ > +#define IPPROTO_AH 51 /* IP6 Auth Header */ Why IP6 for ESP and AH. Isn't it IPsec? > +#define IPPROTO_NONE 59 /* IPv6 no next header */ > +#define IPPROTO_DSTOPTS 60 /* IP6 destination option */ > +#define IPPROTO_SCTP 132 /* Stream Control Transmission Protocol */ There are some strange tabs above. Please replace IP6 with IPv6. Which values are really used currently in DPDK? Or which ones are not?