From: Thomas Monjalon <thomas@monjalon.net>
To: Remy Horton <remy.horton@intel.com>
Cc: dev@dpdk.org, gaetan.rivet@6wind.com, ophirmu@mellanox.com,
ferruh.yigit@intel.com, arybchenko@solarflare.com,
olivier.matz@6wind.com
Subject: Re: [dpdk-dev] [PATCH 3/4] ethdev: move representor parsing functions
Date: Tue, 09 Oct 2018 15:25:27 +0200 [thread overview]
Message-ID: <10928776.jD7b5uRBEX@xps> (raw)
In-Reply-To: <73ffc68e-0a1f-de2a-790e-6bd4941fddef@intel.com>
09/10/2018 14:38, Remy Horton:
>
> On 09/10/2018 03:18, Thomas Monjalon wrote:
> > The functions for representor devargs parsing were static
> > in the file rte_ethdev.c.
> > In order to reuse them in the file rte_class_eth.c,
> > they are moved to the files ethdev_private.c/.h.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> There is overlap between these functions and some of the rte_kvargs_*()
> functions. Is it feasible/desirable to combine them?
Yes!
This is what I wanted to suggest.
I think we should parse list and range as part of the kvargs library.
Would you be interested to rework those functions in a next release?
next prev parent reply other threads:[~2018-10-09 13:25 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 2:18 [dpdk-dev] [PATCH 0/4] support more ethdev iterator filters Thomas Monjalon
2018-10-09 2:18 ` [dpdk-dev] [PATCH 1/4] kvargs: support list value Thomas Monjalon
2018-10-09 14:14 ` Gaëtan Rivet
2018-10-09 14:31 ` Thomas Monjalon
2018-10-09 15:11 ` Stephen Hemminger
2018-10-09 17:11 ` Thomas Monjalon
2018-10-10 13:12 ` Remy Horton
2018-10-09 2:18 ` [dpdk-dev] [PATCH 2/4] mk: remove broken check Thomas Monjalon
2018-10-09 11:43 ` Neil Horman
2018-10-09 11:53 ` Thomas Monjalon
2018-10-09 18:11 ` Neil Horman
2018-10-09 2:18 ` [dpdk-dev] [PATCH 3/4] ethdev: move representor parsing functions Thomas Monjalon
2018-10-09 9:06 ` Andrew Rybchenko
2018-10-09 12:38 ` Remy Horton
2018-10-09 13:25 ` Thomas Monjalon [this message]
2018-10-09 2:18 ` [dpdk-dev] [PATCH 4/4] ethdev: support representor id for iterating ports Thomas Monjalon
2018-10-09 9:14 ` Andrew Rybchenko
2018-10-10 19:23 ` [dpdk-dev] [PATCH v2 0/4] support more ethdev iterator filters Thomas Monjalon
2018-10-10 19:23 ` [dpdk-dev] [PATCH v2 1/4] kvargs: support list value Thomas Monjalon
2018-10-10 19:23 ` [dpdk-dev] [PATCH v2 2/4] ethdev: move representor parsing functions Thomas Monjalon
2018-10-10 19:23 ` [dpdk-dev] [PATCH v2 3/4] ethdev: support representor id as iterator filter Thomas Monjalon
2018-10-10 19:23 ` [dpdk-dev] [PATCH v2 4/4] ethdev: support MAC address " Thomas Monjalon
2018-10-22 13:15 ` [dpdk-dev] [PATCH v3 0/4] support more ethdev iterator filters Thomas Monjalon
2018-10-22 13:15 ` [dpdk-dev] [PATCH v3 1/4] kvargs: support list value Thomas Monjalon
2018-10-22 13:15 ` [dpdk-dev] [PATCH v3 2/4] ethdev: move representor parsing functions Thomas Monjalon
2018-10-22 13:15 ` [dpdk-dev] [PATCH v3 3/4] ethdev: support representor id as iterator filter Thomas Monjalon
2018-10-22 13:15 ` [dpdk-dev] [PATCH v3 4/4] ethdev: support MAC address " Thomas Monjalon
2018-10-22 13:37 ` Andrew Rybchenko
2018-10-22 14:02 ` Thomas Monjalon
2018-10-22 14:18 ` Andrew Rybchenko
2018-10-22 21:24 ` Ananyev, Konstantin
2018-10-23 7:20 ` Thomas Monjalon
2018-10-23 8:33 ` Ananyev, Konstantin
2018-10-23 8:53 ` Thomas Monjalon
2018-10-23 21:45 ` Ananyev, Konstantin
2018-10-22 14:25 ` Andrew Rybchenko
2018-10-24 8:27 ` [dpdk-dev] [PATCH v3 0/4] support more ethdev iterator filters Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10928776.jD7b5uRBEX@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=olivier.matz@6wind.com \
--cc=ophirmu@mellanox.com \
--cc=remy.horton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).