From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 480701B4DC for ; Tue, 9 Oct 2018 15:25:30 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CC2A221F47; Tue, 9 Oct 2018 09:25:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 09 Oct 2018 09:25:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=MwnzE1VfetFvAs0L2TZ/dsOPVxDuviw9hAYFot89nqo=; b=Q8cc6sO82Q+L llIYbMvCwELCG2Jwpfxox7fsRf3F5iciXmm4U5n0J/f3AoKpSA7NA/jlfDpOQPyV n8f1N/2WHqvGFuSh6G20EussK8kVgLmVF0y9V+sF3cm/tCxX4E/yj2+bP3YEDdCs +6uEvFUS09cETpVf8dClWsGy/cqEwbQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=MwnzE1VfetFvAs0L2TZ/dsOPVxDuviw9hAYFot89n qo=; b=UqJnRBZTWdfp+o10mq2gQZz6eTYtp+U4UjSTF6JBmgp0uKH2LGI/hYI7j ZRhq0Ciee+UmCB2fmnY264//SC7nN6ryl0dLODEqlOyNf2Ljqxk8vZ5mkqzeqYVC M9iuKPbuoSCbKdmKrPUGo0Qs+IBrGz3USgUIvKPOzrnZ8WCwonLlfKKLHtZZrGyT KXfoiW3u4y0L9gRrdfgWQJAUFeKTE97/AW1p9LTm2AzVj6YNhVq9FHJiBAtj7kmG SgtYBw1bejxZIYTvu6cJ53MmdXjMwVlBlxEm5bu1ktKtNYW5mVp0sFeAscR/3Tpt FEd56nNJfEa4om8CfXl76cf08RO5Q== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 63844102EE; Tue, 9 Oct 2018 09:25:28 -0400 (EDT) From: Thomas Monjalon To: Remy Horton Cc: dev@dpdk.org, gaetan.rivet@6wind.com, ophirmu@mellanox.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, olivier.matz@6wind.com Date: Tue, 09 Oct 2018 15:25:27 +0200 Message-ID: <10928776.jD7b5uRBEX@xps> In-Reply-To: <73ffc68e-0a1f-de2a-790e-6bd4941fddef@intel.com> References: <20181009021858.19216-1-thomas@monjalon.net> <20181009021858.19216-4-thomas@monjalon.net> <73ffc68e-0a1f-de2a-790e-6bd4941fddef@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 3/4] ethdev: move representor parsing functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 13:25:30 -0000 09/10/2018 14:38, Remy Horton: > > On 09/10/2018 03:18, Thomas Monjalon wrote: > > The functions for representor devargs parsing were static > > in the file rte_ethdev.c. > > In order to reuse them in the file rte_class_eth.c, > > they are moved to the files ethdev_private.c/.h. > > > > Signed-off-by: Thomas Monjalon > > There is overlap between these functions and some of the rte_kvargs_*() > functions. Is it feasible/desirable to combine them? Yes! This is what I wanted to suggest. I think we should parse list and range as part of the kvargs library. Would you be interested to rework those functions in a next release?