From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 35A1258EC for ; Fri, 26 Oct 2018 01:07:11 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CA9C621FA4; Thu, 25 Oct 2018 19:07:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 25 Oct 2018 19:07:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=vrQaXhlhGaZDclW7v5stBzR1tpzaGzOuuLbyc7s6fds=; b=bUFfc+C8DO3U dpYGzToXXZLcOdEg1pnjcBYEgSjJu7I90hScKRO9/b81vdUyE/cHz81BPqGI2lFU z+ix1LKpPYX5/z3GoyvB3tl3uGvQ2WfL8kSinFk7ZCjSLJm+M7934mp7X6XryW2n LwN6T4yVInf463sfhSH7EeDc5Tey7H0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=vrQaXhlhGaZDclW7v5stBzR1tpzaGzOuuLbyc7s6f ds=; b=xDgJfq9doti09nQpKNQY/QEkYWRxVbxEcqS4fevfnBDvdv25VGIihP5WI 1rjDV+YWOFUS/obiYVbmaLL/chhihzkbHtUc/R6BvUS/wmEQCxxRBN0TkHGIW/dc M+IdUj60S4/QfR7GKZdixd8zX3SXSaeOE69+sS9kH2pBm8XrJrcdjE6+k7PO6+6O hrYv0ILHtmiN2tPJ0ynIqJlA/enpKpj7/cZcbmmYXW3fQ8KcFZ/OWVQG521qYGuI pVFI4+waxlA+37fD86wnb8jT9JBZIR7ez6u71slHim7QZ4Vt0BKTdsw3fNbqjy80 hmOfjoWkWcUbG3fDEyGF8o2T/r+JA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 49297102F7; Thu, 25 Oct 2018 19:07:09 -0400 (EDT) From: Thomas Monjalon To: "Wang, Yipeng1" Cc: dev@dpdk.org, Honnappa Nagarahalli , "Mcnamara, John" , "Gobriel, Sameh" , nd Date: Fri, 26 Oct 2018 01:07:12 +0200 Message-ID: <10943078.SV4r761JHd@xps> In-Reply-To: References: <1539206862-306341-1-git-send-email-yipeng1.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] doc: update release note for hash library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 23:07:11 -0000 25/10/2018 20:45, Wang, Yipeng1: > > -----Original Message----- > > From: Honnappa Nagarahalli [mailto:Honnappa.Nagarahalli@arm.com] > > > > > > +* **Added extendable bucket feature to hash library (rte_hash).** > > > + > > > + This new =E2=80=9Cextendable bucket=E2=80=9D feature provides 100%= insertion > > > + guarantee to the capacity specified by the user by extending hash > > > + table with extra buckets when needed to accommodate the unlikely > > > + event of intensive hash collisions. In addition, the internal > > > + hashing algorithm was changed to use partial-key hashing to improve > > Do we need to provide the reference to partial-key hashing paper? > >=20 > [Wang, Yipeng] Sorry for the delay, I thought I replied... >=20 > I assumed it should be a 1-2 sentence summary so I did not include the ci= tation. >=20 > @John, do you think it is good to include reference here? The original id= ea is from a paper which > I referenced in the source code comments and commit message. It's really better when release notes are updated in the same patch as the code. I have inserted it in your patches when applying them. I think the citation is not so important in the release notes.